Skip to content

Commit

Permalink
Use always() instead of !cancelled()
Browse files Browse the repository at this point in the history
Normally you want to avoid `always()` in favor of `!cancelled()`, but in this case we want to use `always()` because using `!cancelled()` would lead to the `ci` job being skipped, which would report as a success for the status check.
  • Loading branch information
jrhemstad authored Oct 24, 2023
1 parent bf893f4 commit 82f99c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ jobs:
ci:
runs-on: ubuntu-latest
name: CI
if: ${{ !cancelled() }}
if: ${{ always() }} # need to use always() instead of !cancelled() because skipped jobs count as success
needs:
- clang-cuda
- cub
Expand Down

0 comments on commit 82f99c3

Please sign in to comment.