Refactor allocator handling of contiguous_storage #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bernhardmgruber
force-pushed
the
alloc
branch
from
0328e81 to
d7c2803
Compare
bernhardmgruber
commented
Dec 4, 2024
miscco
approved these changes
Dec 4, 2024
I was hunting a potential bug where the allocator was seemingly swapped twice in some cases, only to find out later that the code is actually correct. This PR proposes the simplifications I made on the way.
Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
bernhardmgruber
force-pushed
the
alloc
branch
from
093c2ff to
84847d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hunting a potential bug where the allocator was seemingly swapped twice in some cases, only to find out later that the code is actually correct. This PR proposes the simplifications I made on the way.