-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cuda::device::barrier_expect_tx
#498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Sep 28, 2023
ahendriksen
force-pushed
the
add-barrier-expect-tx
branch
from
September 29, 2023 10:21
c4a9eb7
to
93cb861
Compare
griwes
approved these changes
Oct 13, 2023
ahendriksen
force-pushed
the
add-barrier-expect-tx
branch
from
October 16, 2023 10:08
d0ffa9c
to
98381f7
Compare
ahendriksen
requested review from
wmaxey and
elstehle
and removed request for
a team
October 16, 2023 14:06
miscco
reviewed
Oct 17, 2023
Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
ahendriksen
commented
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. Comments addressed.
miscco
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #497
This PR adds the
cuda::device::barrier_expect_tx
function that adjusts the expected transaction count of a shared memory barrier.Checklist