-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read tests for TimeSeries
#124
Open
oruebel
wants to merge
9
commits into
add_read
Choose a base branch
from
add_read_field_read_tests
base: add_read
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add_read #124 +/- ##
============================================
+ Coverage 90.87% 91.01% +0.13%
============================================
Files 53 53
Lines 3289 3349 +60
Branches 229 229
============================================
+ Hits 2989 3048 +59
- Misses 290 291 +1
Partials 10 10 ☔ View full report in Codecov by Sentry. |
…pecific write method from BaseIO to TimeSeries
@stephprince this PR is now ready for you to take a look at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for read. for
TimeSeries
For every neurodata_type we should test that: a) the type itself can be read from file, and b) that allDEFINE_FIELDS
specified for read can be read.TimeSeries
As part of writing the tests for TimeSeries, we should also double-check that all fields that AqNWB writes, that they are also exposed for read and that all types listed for read are also written.
TimeSeries.data.offset
attribute on writeTimeSeries.data.continuity
attribute on writecontrol
andcontrol_description
datasets on write (read viareadControlDescription
andreadControl
)starting_time
dataset and corresponding attributesunit
andrate
on write (read viareadStartingTime
,readStartingTimeUnit
,readStartingTimeRate
Fix #32