Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read tests for TimeSeries #124

Open
wants to merge 9 commits into
base: add_read
Choose a base branch
from
Open

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 9, 2025

Add unit tests for read. for TimeSeries For every neurodata_type we should test that: a) the type itself can be read from file, and b) that all DEFINE_FIELDS specified for read can be read.

  • Add base read test for TimeSeries

As part of writing the tests for TimeSeries, we should also double-check that all fields that AqNWB writes, that they are also exposed for read and that all types listed for read are also written.

  • Add missing TimeSeries.data.offset attribute on write
  • Add missing TimeSeries.data.continuity attribute on write
  • Add missing fields control and control_description datasets on write (read via readControlDescription andreadControl)
  • Add missing field starting_time dataset and corresponding attributes unit and rate on write (read via readStartingTime, readStartingTimeUnit, readStartingTimeRate
  • Move the creation of neurodata_type and namespace attributes to Container and add corresponding DEFINE_FIELDs for read

Fix #32

@oruebel oruebel mentioned this pull request Jan 9, 2025
72 tasks
@oruebel oruebel changed the base branch from main to add_read January 9, 2025 03:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (44e957d) to head (b91dd24).

Additional details and impacted files
@@             Coverage Diff              @@
##           add_read     #124      +/-   ##
============================================
+ Coverage     90.87%   91.01%   +0.13%     
============================================
  Files            53       53              
  Lines          3289     3349      +60     
  Branches        229      229              
============================================
+ Hits           2989     3048      +59     
- Misses          290      291       +1     
  Partials         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel changed the title Add read field read tests Add read tests for TimeSeries Jan 9, 2025
@oruebel oruebel marked this pull request as ready for review January 9, 2025 20:01
@oruebel
Copy link
Contributor Author

oruebel commented Jan 9, 2025

@stephprince this PR is now ready for you to take a look at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants