Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 프로필 not null 필드만 업데이트하도록 수정 #54

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

songyi00
Copy link
Member

Issue Number

close: #52

작업 개요

  • null 체크 보완이 필요해서 코드 수정합니다. (프로필 설정하지 않은 사용자에 대해 중복 닉네임 여부 검증하지 않도록 수정)

작업 사항

여기에 작성하세요

고민한 점들(필수 X)

여기에 작성하세요

스크린샷(필수 X)

여기에 작성하세요

@songyi00 songyi00 requested a review from kimyu0218 as a code owner August 13, 2024 11:22
Copy link
Collaborator

@kimyu0218 kimyu0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 👏👏

@@ -28,10 +28,12 @@ public ProfileResponse getMember(final Long memberId) {

@Transactional
public void updateProfile(final UpdateProfileCommand request) {
validateNickname(request.nickname());
request.nickname().ifPresent(this::validateNickname);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@songyi00 songyi00 merged commit 8b80aba into develop Aug 13, 2024
1 check passed
@songyi00 songyi00 deleted the feat/#52-profile branch August 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로필 수정 요청시 nullable 처리
2 participants