Fix argument order in the Windows implementation of getEnvOs
#11855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
added
the
backport 2.24-maintenance
|
Oh we are missing the Mergify config for Nix 2.25 |
See the build failure in msys2/MINGW-packages#22499
Ericson2314
force-pushed
the
fix-windows-env-var-arg-order
branch
from
569e6db to
355f08a
Compare
|
I think there's a clang-tidy check for this 🥲. https://clang.llvm.org/extra/clang-tidy/checks/bugprone/string-constructor.html |
edolstra
added
the
backport 2.25-maintenance
|
@xokdvium that's great! And to be clear I support all your clang-tidy work! Thank you for proposing it! |
roberth
added
backport 2.25-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See the build failure in msys2/MINGW-packages#22499
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
CC @puffnfresh