Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cfs-zen-tweaks #223952

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix cfs-zen-tweaks #223952

merged 2 commits into from
Jun 15, 2023

Conversation

m-bdf
Copy link
Contributor

@m-bdf m-bdf commented Mar 30, 2023 •
edited
Loading

Description of changes

Fixes cfs-zen-tweaks package (exec bit missing on script) and module (typo in systemd service name).

NB: the upstream project's owner doesn't want to maintain it anymore, so we might want to deprecate the package/module here at some point?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 30, 2023
@ofborg ofborg bot requested a review from mkg20001 March 30, 2023 20:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 30, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2279

@m-bdf m-bdf force-pushed the fix-cfs-zen-tweaks branch from 7deced5 to 4017ae3 Compare June 13, 2023 16:20
@mkg20001 mkg20001 merged commit 95c729c into NixOS:master Jun 15, 2023
@m-bdf m-bdf deleted the fix-cfs-zen-tweaks branch June 15, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@mkg20001 mkg20001 Awaiting requested review from mkg20001

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-bdf @nixos-discourse @SuperSandro2000 @mkg20001