Switched to Geometric Mean for Peptide Level Scores #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilferrit
commented
Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #392 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 13 13
Lines 1102 1102
=======================================
Hits 1040 1040
Misses 62 62 ☔ View full report in Codecov by Sentry. |
bittremieux
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Looks good.
Two minor suggestions:
- Maybe add another test that doesn't include a
0amino acid score, because of the resulting-inflog and zero geometric mean. This is an edge case anyway, because real amino acid scores will likely never be truly zero. - Update the CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the peptide level score calculation from the arithmetic mean to the geometric mean of amino acid scores.