-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more features #11
Merged
Merged
more features #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHO NEEDS STACK MAPS ANYWAY
Nolij
requested changes
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a full review. Just the initial skimming of the diff.
Nolij
requested changes
Aug 7, 2024
Nolij
reviewed
Aug 7, 2024
embeddedt
requested changes
Aug 13, 2024
it's not ready for 1.0 yet :(
Nolij
approved these changes
Aug 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nested objects/arrays/collections as fields in POJOs work
and for the most part (as far as I can tell) everything follows the json5 spec
also the java 8 jar is actually java 5 (which makes it smaller)
I added some more comments too, as well as publishing a javadoc jar
note that 2d arrays do not work, I still need to figure out how to do those nicely
closes #10