Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more features #11

Merged
merged 24 commits into from
Aug 17, 2024
Merged

more features #11

merged 24 commits into from
Aug 17, 2024

Conversation

rhysdh540
Copy link
Contributor

@rhysdh540 rhysdh540 commented Jul 20, 2024

nested objects/arrays/collections as fields in POJOs work
and for the most part (as far as I can tell) everything follows the json5 spec
also the java 8 jar is actually java 5 (which makes it smaller)
I added some more comments too, as well as publishing a javadoc jar

note that 2d arrays do not work, I still need to figure out how to do those nicely

closes #10

Copy link
Owner

@Nolij Nolij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a full review. Just the initial skimming of the diff.

src/main/java/dev/nolij/zson/Zson.java Outdated Show resolved Hide resolved
@rhysdh540 rhysdh540 requested a review from Nolij August 6, 2024 21:19
build.gradle.kts Show resolved Hide resolved
src/main/java/dev/nolij/zson/Zson.java Outdated Show resolved Hide resolved
src/main/java/dev/nolij/zson/Zson.java Outdated Show resolved Hide resolved
src/test/java/NoJUnitTest.java Outdated Show resolved Hide resolved
@Nolij Nolij merged commit 5434f7d into Nolij:master Aug 17, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

full json5 support
3 participants