Add way to deal with missing expiration date #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bug in SP, but it sems quite widespread, so allow way to handle this using configuration. See OTA-Insight#96
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 97.40% 97.15% -0.26%
==========================================
Files 6 6
Lines 347 351 +4
==========================================
+ Hits 338 341 +3
- Misses 9 10 +1
Continue to review full report at Codecov.
|
|
Thanks for the fix, I never did finish looking into the issue that you linked! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug in SP, but it sems quite widespread, so allow way to
handle this using configuration.
See #96