Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Authentication_Cheat_Sheet.md #1245

Conversation

philCryoport
Copy link
Contributor

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #1243

Thank you again for your contribution 😃

@philCryoport philCryoport marked this pull request as ready for review December 1, 2023 20:36
@philCryoport
Copy link
Contributor Author

philCryoport commented Dec 1, 2023

Am I reading this correctly -- where there needs to be a code-owner approval before linting happens?
image

I would rather know my content fails linting -- and correct that -- before sending it for code-owner approval.

Also, seems like linting is also blocked when a PR is in draft state. Again, there it would be useful to know if my content fails linting...

@philCryoport philCryoport marked this pull request as draft December 1, 2023 20:44
@philCryoport
Copy link
Contributor Author

Never mind, I found where it was buried in the contribution guide

@philCryoport philCryoport marked this pull request as ready for review December 1, 2023 20:51
@philCryoport
Copy link
Contributor Author

Ok Markdown plugin no longer complaining in VSCodium

@philCryoport philCryoport marked this pull request as draft December 1, 2023 20:56
@philCryoport philCryoport marked this pull request as ready for review December 1, 2023 21:00
@jmanico
Copy link
Member

jmanico commented Dec 3, 2023

I feel this guidance is more verbose than it needs to be. For starters, we can drop the MFA part and some of the less-than-necessary steps. For example, maybe one list like this?

  1. New Email Submission: Request and validate the new email address for an authenticated user.
  2. Identity Verification: Require re-authentication to verify user identity.
  3. Send a notification to the old email address regarding the change request.
  4. Send a confirmation request to the new email with a confirmation link.
  5. If confirmed, update the email address.

This is just a cheat-sheet, I want to keep the guidance short and to the point.

Thank you!

@philCryoport
Copy link
Contributor Author

philCryoport commented Dec 4, 2023

I feel this guidance is more verbose than it needs to be. For starters, we can drop the MFA part and some of the less-than-necessary steps. For example, maybe one list like this?

1. New Email Submission: Request and validate the new email address for an authenticated user.

2. Identity Verification: Require re-authentication to verify user identity.

3. Send a notification to the old email address regarding the change request.

4. Send a confirmation request to the new email with a confirmation link.

5. If confirmed, update the email address.

This is just a cheat-sheet, I want to keep the guidance short and to the point.

Thank you!

Hi @jmanico

Agreed, this is a cheat sheet, so I'll shorten the section.

However, I'd still like to offer up these step-by-step processes if OWASP agrees they are the correct way to prevent an account takeover.

Should I publish these in https://owasp.org/www-community/controls/ ?

Is there a better place to publish them?

@jmanico
Copy link
Member

jmanico commented Dec 8, 2023

I do like this content, but it's a little sloppy and the language needs to be cleaned up. And needs to be massively reduced. I'll help when I can, this is a very solid idea, it just needs a lot of cleanup.

@jmanico
Copy link
Member

jmanico commented Dec 8, 2023

I feel this guidance is more verbose than it needs to be. For starters, we can drop the MFA part and some of the less-than-necessary steps. For example, maybe one list like this?

1. New Email Submission: Request and validate the new email address for an authenticated user.

2. Identity Verification: Require re-authentication to verify user identity.

3. Send a notification to the old email address regarding the change request.

4. Send a confirmation request to the new email with a confirmation link.

5. If confirmed, update the email address.

This is just a cheat-sheet, I want to keep the guidance short and to the point.
Thank you!

Hi @jmanico

Agreed, this is a cheat sheet, so I'll shorten the section.

However, I'd still like to offer up these step-by-step processes if OWASP agrees they are the correct way to prevent an account takeover.

Should I publish these in https://owasp.org/www-community/controls/ ?

Is there a better place to publish them?

And yes a community page is the right place for the total content and I can help you clean it up. AI can help. Send all your text into a LLM and ask for cleanup and you'll see what I mean.

@philCryoport
Copy link
Contributor Author

I feel this guidance is more verbose than it needs to be. For starters, we can drop the MFA part and some of the less-than-necessary steps. For example, maybe one list like this?

1. New Email Submission: Request and validate the new email address for an authenticated user.

2. Identity Verification: Require re-authentication to verify user identity.

3. Send a notification to the old email address regarding the change request.

4. Send a confirmation request to the new email with a confirmation link.

5. If confirmed, update the email address.

This is just a cheat-sheet, I want to keep the guidance short and to the point.
Thank you!

Hi @jmanico
Agreed, this is a cheat sheet, so I'll shorten the section.
However, I'd still like to offer up these step-by-step processes if OWASP agrees they are the correct way to prevent an account takeover.
Should I publish these in owasp.org/www-community/controls ?
Is there a better place to publish them?

And yes a community page is the right place for the total content and I can help you clean it up. AI can help. Send all your text into a LLM and ask for cleanup and you'll see what I mean.

Roger that.

@philCryoport
Copy link
Contributor Author

philCryoport commented Dec 11, 2023

Hi @jmanico LLM indeed cleaned it up. How is it now?

@jmanico jmanico merged commit 4e204a8 into OWASP:master Dec 18, 2023
3 checks passed
@philCryoport
Copy link
Contributor Author

Thank you!

@philCryoport philCryoport deleted the Update-Authentication-Cheat-Sheet-to-Describe-Changing-of-Registered-Email-Address branch January 9, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants