Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct type of clobbered object properties from HTMLElement to Element #1504

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Correct type of clobbered object properties from HTMLElement to Element #1504

merged 1 commit into from
Oct 1, 2024

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Sep 30, 2024

DOM clobbering could be performed with an SVGElement or MathMLElement, which are subclasses of Element but not of HTMLElement, so checking instanceof HTMLElement does not suffice to exclude them.

@mackowski mackowski requested review from jmanico and szh October 1, 2024 09:11
@jmanico jmanico merged commit 9c67e3a into OWASP:master Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackowski mackowski mackowski approved these changes

@jmanico jmanico jmanico approved these changes

@szh szh Awaiting requested review from szh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersk @jmanico @mackowski