Fix vehicle location response (#240)

OWASP · Mar 20, 2024 · 8ac6134 · 8ac6134
1 parent daef452
commit 8ac6134
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/services/identity/src/main/java/com/crapi/model/VehicleLocationResponse.java b/services/identity/src/main/java/com/crapi/model/VehicleLocationResponse.java
@@ -24,12 +24,15 @@ public class VehicleLocationResponse {
   private UUID carId;
   private VehicleLocation vehicleLocation;
   private String fullName;
+  private String email;
 
   public VehicleLocationResponse() {}
 
-  public VehicleLocationResponse(UUID id, String name, VehicleLocation vehicleLocation) {
+  public VehicleLocationResponse(
+      UUID id, String name, String email, VehicleLocation vehicleLocation) {
     this.carId = id;
     this.fullName = name;
+    this.email = email;
     this.vehicleLocation = vehicleLocation;
   }
 }
diff --git a/services/identity/src/main/java/com/crapi/service/Impl/VehicleServiceImpl.java b/services/identity/src/main/java/com/crapi/service/Impl/VehicleServiceImpl.java
@@ -160,6 +160,7 @@ public VehicleLocationResponse getVehicleLocation(UUID carId) {
               new VehicleLocationResponse(
                   carId,
                   (userDetails != null ? userDetails.getName() : null),
+                  (userDetails != null ? userDetails.getUser().getEmail() : null),
                   vehicleDetails.getVehicleLocation());
           return vehicleLocationForm;
         }

diff --git a/services/identity/src/test/java/com/crapi/service/Impl/VehicleServiceImplTest.java b/services/identity/src/test/java/com/crapi/service/Impl/VehicleServiceImplTest.java
@@ -143,6 +143,7 @@ public void getVehicleLocationSuccessWithUserDetailsNotNull() {
         vehicleService.getVehicleLocation(vehicleDetails.getUuid());
     Assertions.assertNotNull(vehicleLocationResponse);
     Assertions.assertEquals(userDetails.getName(), vehicleLocationResponse.getFullName());
+    Assertions.assertEquals(userDetails.getUser().getEmail(), vehicleLocationResponse.getEmail());
   }
 
   @Test