Skip to content

Commit

Permalink
manual macos notarization
Browse files Browse the repository at this point in the history
  • Loading branch information
jgadsden authored Nov 26, 2024
2 parents d8dba40 + 60be55b commit f29f5bc
Show file tree
Hide file tree
Showing 5 changed files with 167 additions and 973 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ jobs:
run: npm start

- name: ZAP Scan
uses: zaproxy/action-full-scan@v0.11.0
uses: zaproxy/action-full-scan@v0.12.0
with:
token: ${{ secrets.GITHUB_TOKEN }}
target: 'http://localhost:8080'
Expand Down Expand Up @@ -296,7 +296,7 @@ jobs:
- name: Build for amd64
id: docker_build
uses: docker/build-push-action@v6.9.0
uses: docker/build-push-action@v6.10.0
with:
context: ./
file: ./Dockerfile
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ jobs:
# platform manifests not (yet) supported, so split out architectures
- name: Build for amd64 and push latest
id: docker_build_amd64
uses: docker/build-push-action@v6.9.0
uses: docker/build-push-action@v6.10.0
with:
context: ./
file: ./Dockerfile
Expand All @@ -208,7 +208,7 @@ jobs:

- name: Build for arm64 and push latest-arm64
id: docker_build_arm64
uses: docker/build-push-action@v6.9.0
uses: docker/build-push-action@v6.10.0
with:
context: ./
file: ./Dockerfile
Expand Down Expand Up @@ -421,7 +421,7 @@ jobs:
uses: actions/checkout@v4.2.0

- name: ZAP Scan
uses: zaproxy/action-full-scan@v0.11.0
uses: zaproxy/action-full-scan@v0.12.0
with:
token: ${{ secrets.GITHUB_TOKEN }}
target: 'http://localhost:3000'
Expand Down
18 changes: 13 additions & 5 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,11 @@ jobs:
CSC_KEY_PASSWORD: ${{ secrets.MAC_CERTS_PASSWORD }}
CSC_LINK: ${{ secrets.MAC_CERTS }}
# MacOS notarization: see github.com/electron/notarize#readme
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
API_KEY_ID: ${{ secrets.API_KEY_ID }}
API_KEY_ISSUER_ID: ${{ secrets.API_KEY_ISSUER_ID }}
# APPLE_ID: ${{ secrets.APPLE_ID }}
# APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
# APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
defaults:
run:
working-directory: td.vue
Expand All @@ -209,6 +211,12 @@ jobs:
- name: Install clean packages
run: npm clean-install

- name: Prepare for MacOS notarization
# Import Apple API key to support signing of app
run: |
mkdir -p ~/private_keys/
echo '${{ secrets.API_KEY }}' > ~/private_keys/AuthKey_${{ secrets.API_KEY_ID }}.p8
- name: Publish MacOS disk image
run: npm run build:desktop -- --mac --publish always

Expand Down Expand Up @@ -366,7 +374,7 @@ jobs:
# platform manifests not (yet) supported, so split out architectures
- name: Build for amd64 and push to Docker Hub
id: docker_build_amd64
uses: docker/build-push-action@v6.9.0
uses: docker/build-push-action@v6.10.0
with:
context: ./
file: ./Dockerfile
Expand All @@ -380,7 +388,7 @@ jobs:

- name: Build for arm64 and push to Docker Hub
id: docker_build_arm64
uses: docker/build-push-action@v6.9.0
uses: docker/build-push-action@v6.10.0
with:
context: ./
file: ./Dockerfile
Expand Down
Loading

0 comments on commit f29f5bc

Please sign in to comment.