Skip to content

Commit

Permalink
noahdarveau/debug polyfill bug fix (#2661)
Browse files Browse the repository at this point in the history
* explicitly uses browser implementation of debug
  • Loading branch information
noahdarveau-MSFT authored Dec 18, 2024
1 parent 5f55f62 commit 7536e04
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Explicitly use browser implementation of `debug` package to resolve polyfill issue.",
"packageName": "@microsoft/teams-js",
"email": "109628470+noahdarveau-MSFT@users.noreply.github.com",
"dependentChangeType": "patch"
}
6 changes: 0 additions & 6 deletions packages/teams-js/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ export default [
entryFileNames: '[name].js',
sourcemap: false,
plugins: [terser()],
globals: {
buffer: 'Buffer',
tty: 'tty',
util: 'util',
os: 'os',
},
},
preserveEntrySignatures: 'strict',
plugins: [
Expand Down
3 changes: 2 additions & 1 deletion packages/teams-js/src/internal/telemetry.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { debug as registerLogger, Debugger } from 'debug';
// We are directly referencing the browser implementation of `debug` to resolve an issue with polyfilling. For a full write-up on the bug please see ADO Bug #9619161
import { debug as registerLogger, Debugger } from 'debug/src/browser';

import { UUID } from './uuidObject';

Expand Down

0 comments on commit 7536e04

Please sign in to comment.