Set task as Canceled based on token

OmniSharp · Feb 13, 2024 · 68680df · 68680df
1 parent 8ac5cf7
commit 68680df
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/JsonRpc/ResponseRouter.cs b/src/JsonRpc/ResponseRouter.cs
@@ -101,10 +101,10 @@ public async Task<TResponse> Returning<TResponse>(CancellationToken cancellation
                 var tcs = new TaskCompletionSource<JToken>();
                 _router.Requests.TryAdd(nextId, ( _method, tcs ));
 
-                cancellationToken.ThrowIfCancellationRequested();
-
                 try
                 {
+                    cancellationToken.ThrowIfCancellationRequested();
+
                     _router.OutputHandler.Value.Send(
                         new OutgoingRequest
                         {
@@ -117,6 +117,13 @@ public async Task<TResponse> Returning<TResponse>(CancellationToken cancellation
                         () =>
                         {
                             if (tcs.Task.IsCompleted) return;
+
+                            if (cancellationToken.IsCancellationRequested)
+                            {
+                                tcs.SetCanceled();
+                                return;
+                            }
+
                             _router.CancelRequest(new CancelParams { Id = nextId });
                         }
                     );