Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual model loading #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Manual model loading #8

wants to merge 3 commits into from

Conversation

ashpieboop
Copy link
Contributor

For when you want to use an obj model for other renders than blocks or item.

@ashpieboop ashpieboop force-pushed the manual-model-loading branch 3 times, most recently from 732fb98 to 71aa6a8 Compare February 21, 2020 10:44
@ashpieboop ashpieboop marked this pull request as ready for review February 21, 2020 13:17
@comp500
Copy link

comp500 commented Feb 24, 2020 •
edited
Loading

This PR doesn't seem to stitch model textures properly. Texture stitching happens at the end of the construction of ModelLoader, before ModelLoaderMixin::init runs, so model textures aren't part of the texture atlas.

@ashpieboop
Copy link
Contributor Author

@comp500 thanks for catching that! I'm going to add a use case in the test mod to highlight this, then I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashpieboop @comp500