Added interpolation of results to arbitrary nodes, removed use of scipy.interpolate.interp1d from phase.interp.
#1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ues in interpolation.
…d interpolate function from phase.
…ion instead of gl
swryan
approved these changes
Nov 15, 2024
| # self.rho_interp = InterpND(points=np.array(alt_data), | ||
| # values=np.array(rho_data), | ||
| # method='slinear', extrapolate=True) | ||
| self.rho_interp = make_interp_spline(alt_data, rho_data, k=1) |
| p.driver = om.pyOptSparseDriver() | ||
| p.driver.options['optimizer'] = 'IPOPT' | ||
| p.driver = om.ScipyOptimizeDriver() | ||
| # p.driver.options['optimizer'] = 'SLSQP' |
| res = np.atleast_2d(interpfunc(node_locations)) | ||
|
|
There was a problem hiding this comment.
If reversed_xs, do you need to flip the indices on res before returning it?
There was a problem hiding this comment.
No I don't think so. By flipping the results returned by unique, which are always sorted, we recover the requested ordering.
Kenneth-T-Moore
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
phase.interpto obtain outputs on any set of points in phase tau space [-1, 1].phase.interpto usescipy.interpolate.make_interp_spline. Spline types that are no longer supported will now result in linear interpolation.Phase.interpolatemethod. users should usePhase.interp.ScipyOptimizeDriver.In general IPOPT on the latest workflow seems to be having issues with converging some of the problems, but it's not obvious yet as to why. Need to keep an eye on it.
Related Issues
Backwards incompatibilities
-
Phase.interpolateis removed in favor ofPhase.interp.New Dependencies
None