Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test run on Net8 #458

Merged
merged 12 commits into from
Dec 18, 2023
Merged

Make test run on Net8 #458

merged 12 commits into from
Dec 18, 2023

Conversation

SandstromErik
Copy link
Contributor

@SandstromErik SandstromErik commented Nov 7, 2023 •
edited
Loading

Make all test running on Net6 also run on Net8

  • Make code gen console app test work

@Daniel-Svensson Daniel-Svensson mentioned this pull request Nov 28, 2023
Merged
Daniel-Svensson
Daniel-Svensson approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@Daniel-Svensson Daniel-Svensson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small comments, good work

src/OpenRiaServices.Tools/Framework/DataContractProxyGenerator.cs Outdated Show resolved Hide resolved
src/Test/Desktop/TypeLoadExceptionProject/TypeLoadExceptionProject.csproj Outdated Show resolved Hide resolved
src/OpenRiaServices.Tools/Test/ServerClassLib/ServerClassLib.csproj Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

13 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SandstromErik SandstromErik merged commit 9c949f1 into OpenRIAServices:main Dec 18, 2023
6 checks passed
@SandstromErik SandstromErik deleted the feature/firstnet8Update branch December 18, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikoijwall erikoijwall erikoijwall left review comments

@Daniel-Svensson Daniel-Svensson Daniel-Svensson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SandstromErik @Daniel-Svensson @erikoijwall