Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BinaryHttpDomainClient in AspNetCore Test #471

Conversation

SandstromErik
Copy link
Contributor

@SandstromErik SandstromErik commented Dec 19, 2023

Remove obsolete WebDomainClientFactory from AspNetCore tests and use BinaryHttpDomainClientFactory instead.
Modify tests that does not pass

@SandstromErik SandstromErik changed the title Remove obsolete DomainClientFactory from AspNetCore Test Use BinaryHttpDomainClient in AspNetCore Test Dec 20, 2023
Copy link
Member

@Daniel-Svensson Daniel-Svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God work, now it should be possible to add .net6 / .net8 as TargetFramework for the test in a follow up PR:

SandstromErik and others added 2 commits December 22, 2023 11:18
…ts.cs

Co-authored-by: Daniel Svensson <daniel.svensson@hotmail.se>
@SandstromErik SandstromErik enabled auto-merge (squash) December 22, 2023 10:43
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@SandstromErik SandstromErik merged commit f786760 into OpenRIAServices:main Dec 22, 2023
6 checks passed
@SandstromErik SandstromErik deleted the feature/removeObsoleteDomainClientFactoryFromTest branch December 22, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants