add net8.0 and efcore 8.0

Changelog.md

@@ -1,13 +1,37 @@
-# Unreleased
+# Unreleased (5.5.0)
+
+### Server
+* Reduced allocatgions when parsing queries on server (both WCF and AspNetCore hosting) in https://github.com/OpenRIAServices/OpenRiaServices/pull/485
+* Update nuget dependencies and add new dependencies to OpenRiaServices.Hosting.Wcf
+  * `System.Collections.Immutable` and `System.Memory` are new dependencies of Wcf hosting
+
+* .NET Framework builds now includes the smaller portable pdb's instead of of the old "full" windows style pdb's
+  * NOTE: For .NET Framework apps ensure that *supportedRuntime* in *app.config* and corresponding setting in *web.config* does not specify an older runtime if you wan't line numbers in stack traces.
+
+# 5.4.2 / AspNetCore 1.0.0
+
+### .NET8
+* Build with .NET8 sdk and run AspNetCore tests with .NET8 by @Daniel-Svensson in https://github.com/OpenRIAServices/OpenRiaServices/pull/463
+* Run most client, server and code generation tests with .NET8 by @SandstromErik in https://github.com/OpenRIAServices/OpenRiaServices/pull/458
+
+### Code generation
+* Do not use attributes reserved for the compiler in code generation. Will make it possible to use nullable reference types and the `required` modifier for fields and properties by @SandstromErik in https://github.com/OpenRIAServices/OpenRiaServices/pull/472
 
 ### AspNetCore updates
-* Add authentication documentation #466
-* Use FrozenSet in first location (QueryStringConverter)
-* Update versionprefix to 1.0.0 (for next release)
+* Various updates by @Daniel-Svensson in https://github.com/OpenRIAServices/OpenRiaServices/pull/466
+    * Add authentication documentation
+    * Use FrozenSet in first location (QueryStringConverter)
+    * Update versionprefix to 1.0.0 (for next release)
+
+### Testhost
+* Add support in `DomainServiceTestHost` for asynchronous queries that return a single entity by @erikoijwall in https://github.com/OpenRIAServices/OpenRiaServices/pull/464
 
 ### Other
-* Update nuget dependencies for tests
-* Fix test which would sometimes hang
+* Build improvments, including set `MSBUILDDEBUGPATH` allowing troubleshooting of build failures by @Daniel-Svensson in https://github.com/OpenRIAServices/OpenRiaServices/pull/463
+* Update nuget dependencies for tests by @Daniel-Svensson in https://github.com/OpenRIAServices/OpenRiaServices/pull/468
+* Fix test which would sometimes hang by @Daniel-Svensson in https://github.com/OpenRIAServices/OpenRiaServices/pull/469
+* Add tests to see that codegen works with nullable reference types by @Daniel-Svensson in https://github.com/OpenRIAServices/OpenRiaServices/pull/470
+* Use `BinaryHttpDomainClient` in AspNetCore Test by @SandstromErik in https://github.com/OpenRIAServices/OpenRiaServices/pull/471
 
 # 5.4.1
 

NuGet/OpenRiaServices.Hosting.Wcf/OpenRiaServices.Hosting.Wcf.nuspec

@@ -16,13 +16,15 @@
     </description>
     <summary>Open RIA Services - Server-side assemblies and configuration</summary>
     <releaseNotes>For release notes see https://github.com/OpenRIAServices/OpenRiaServices/releases</releaseNotes>
-    <copyright>2019 Outercurve Foundation</copyright>
+    <copyright>2024 .NET Foundation</copyright>
     <language>en-US</language>
     <tags>WCF RIA Services RIAServices Server aspnet OpenRiaServices</tags>
 	<dependencies>
 		<group targetFramework="net472">
+			<dependency id="Microsoft.Extensions.DependencyInjection.Abstractions" version="8.0.0"/>
 			<dependency id="OpenRiaServices.Server" version="$version$"/>
-			<dependency id="Microsoft.Extensions.DependencyInjection.Abstractions" version="7.0.0"/>
+			<dependency id="System.Collections.Immutable" version="8.0.0" />
+			<dependency id="System.Memory" version="4.5.5"/>
 		</group>
 	</dependencies>
   </metadata>
@@ -33,4 +35,4 @@
     <file src="..\..\src\bin\Release\net472\OpenRiaServices.Hosting.Wcf.pdb" target="lib\net472\OpenRiaServices.Hosting.Wcf.pdb" />
     <file src="..\..\src\bin\Release\net472\OpenRiaServices.Hosting.Wcf.xml" target="lib\net472\OpenRiaServices.Hosting.Wcf.xml" />
   </files>
-</package>
+</package>

azure-pipelines.yml

@@ -129,7 +129,7 @@ steps:
     versionEnvVar: Build.BuildNumber
     packDestination: '$(Build.ArtifactStagingDirectory)' 
   continueOnError: true
-  condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest'))
+#  condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest'))
 
 - task: CopyFiles@2
   displayName: 'Copy VS Extension: $(build.artifactstagingdirectory)'

src/Directory.Build.props

@@ -51,13 +51,7 @@
     <AssemblyOriginatorKeyFile Condition="'$(AssemblyOriginatorKeyFile)' == '' And '$(IsTestProject)' == 'true'">$(MSBuildThisFileDirectory)\snk\Tests.snk</AssemblyOriginatorKeyFile>
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
 
-    <!-- opt out from portable pdbs, for better compability with older net framework releases
-    This is required for several test related projects since code generation's 
-    pdb reader cannot read the portable ones
-    -->
     <DebugType>portable</DebugType>
-    <DebugType Condition="$(TargetFramework.StartsWith('net4')) OR '$(IsTestProject)'=='true'">pdbonly</DebugType>
-
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(GitVersion_AssemblySemVer)' != ''">

src/OpenRiaServices.Client.DomainClients.Http/Framework/SystemServiceModel.Dispatcher/QueryStringConverter.cs

@@ -159,9 +159,9 @@ public virtual string ConvertValueToString(object parameter, Type parameterType)
         [SuppressMessage("Reliability", "Reliability104:CaughtAndHandledExceptionsRule", Justification = "The exception is traced in the finally clause")]
         TypeConverter GetStringConverter(Type parameterType)
         {
-            if (this._typeConverterCache.ContainsKey(parameterType))
+            if (this._typeConverterCache.TryGetValue(parameterType, out TypeConverter typeConverter))
             {
-                return (TypeConverter)this._typeConverterCache[parameterType];
+                return typeConverter;
             }
             TypeConverterAttribute[] typeConverterAttrs = parameterType.GetCustomAttributes(typeof(TypeConverterAttribute), true) as TypeConverterAttribute[];
             if (typeConverterAttrs != null)

src/OpenRiaServices.Client/Framework/ChangeSetBuilder.cs

@@ -149,7 +149,7 @@ internal static void CheckForInvalidUpdates(EntityChangeSet changeSet)
         /// </summary>
         internal class UnmodifiedOperationAdder : EntityVisitor
         {
-            private readonly Dictionary<object, bool> _visited = new Dictionary<object, bool>();
+            private readonly HashSet<object> _visited = new HashSet<object>();
             private readonly List<ChangeSetEntry> _changeSetEntries;
             private int _id;
             private bool _isChild;
@@ -180,7 +180,7 @@ public static void Add(List<ChangeSetEntry> changeSetEntries)
 
             public override void Visit(Entity entity)
             {
-                if (this._visited.ContainsKey(entity))
+                if (!this._visited.Add(entity))
                 {
                     return;
                 }
@@ -192,8 +192,6 @@ public override void Visit(Entity entity)
                     this._changeSetEntries.Add(op);
                 }
 
-                this._visited.Add(entity, true);
-
                 base.Visit(entity);
             }
 

src/OpenRiaServices.Client/Framework/Entity.cs

@@ -250,8 +250,8 @@ private set
                     EntitySet entitySet = this.LastSet;
                     if (entitySet != null)
                     {
-                        bool isInteresting = this._entityState != EntityState.Unmodified
-                            && this._entityState != EntityState.Detached;
+                        bool isInteresting = this._entityState is not EntityState.Unmodified
+                            and not EntityState.Detached;
                         entitySet.TrackAsInteresting(this, isInteresting);
                     }
 
@@ -302,12 +302,9 @@ internal void OnChildUpdate()
                 }
             }
 
-            if (this.EntitySet != null)
-            {
-                // when a child has been changed in any way, the parent becomes
-                // interesting
-                this.EntitySet.TrackAsInteresting(this, true);
-            }
+            // when a child has been changed in any way, the parent becomes
+            // interesting
+            this.EntitySet?.TrackAsInteresting(this, true);
         }
 
         /// <summary>
@@ -526,8 +523,7 @@ private set
                 this._isMerging = value;
                 foreach (MetaMember metaMember in MetaType.DataMembers.Where(f => f.IsComplex && !f.IsCollection))
                 {
-                    ComplexObject propertyValue = metaMember.GetValue(this) as ComplexObject;
-                    if (propertyValue != null)
+                    if (metaMember.GetValue(this) is ComplexObject propertyValue)
                     {
                         propertyValue.IsMergingState = this._isMerging;
                     }
@@ -647,10 +643,7 @@ internal void Reset()
             this._editSession = null;
             this._trackChanges = false;
             UndoAllEntityActions(throwIfSubmitting: true);
-            if (this._validationErrors != null)
-            {
-                this._validationErrors.Clear();
-            }
+            this._validationErrors?.Clear();
             this.EntityConflict = null;
             this.EntitySet = null;
             this._lastSet = null;
@@ -682,8 +675,8 @@ internal void StopTracking()
         /// </summary>
         protected void AcceptChanges()
         {
-            if (this.EntityState == EntityState.Unmodified ||
-                this.EntityState == EntityState.Detached)
+            if (this.EntityState is EntityState.Unmodified or
+                EntityState.Detached)
             {
                 // if we're detached or have no changes, noop after
                 // closing any in progress edit session
@@ -696,11 +689,7 @@ protected void AcceptChanges()
             // Accept any child changes. Note, we must accept child changes before setting our own
             // state to Unmodified. This avoids a situation where we get notifications from child
             // entities that cause our state to flip back to Modified.
-            if (entitySet != null)
-            {
-                // accept any child changes
-                entitySet.EntityContainer.CompleteChildChanges(this, true);
-            }
+            entitySet?.EntityContainer.CompleteChildChanges(this, true);
 
             if (this.EntityState == EntityState.New)
             {
@@ -730,30 +719,21 @@ protected void AcceptChanges()
             else if (this.EntityState == EntityState.Deleted)
             {
                 this.StopTracking();
-                if (entitySet != null)
-                {
-                    entitySet.RemoveFromCache(this);
-                }
+                entitySet?.RemoveFromCache(this);
                 // move back to the default state
                 this.EntityState = EntityState.Detached;
             }
 
-            if (entitySet != null)
-            {
-                // remove from the interesting entities set
-                entitySet.TrackAsInteresting(this, false);
-            }
+            // remove from the interesting entities set
+            entitySet?.TrackAsInteresting(this, false);
 
             // need to end any in progress edit session
             this._editSession = null;
 
             // clear all custom method invocations
             this.UndoAllEntityActions(throwIfSubmitting: false);
 
-            if (this._validationErrors != null)
-            {
-                this._validationErrors.Clear();
-            }
+            this._validationErrors?.Clear();
             this.EntityConflict = null;
             this.IsInferred = false;
             this._hasChildChanges = false;
@@ -769,8 +749,8 @@ protected void AcceptChanges()
         /// </summary>
         protected void RejectChanges()
         {
-            if (this.EntityState == EntityState.Unmodified ||
-                this.EntityState == EntityState.Detached)
+            if (this.EntityState is EntityState.Unmodified or
+                EntityState.Detached)
             {
                 // if we're detached or have no changes, noop after
                 // closing any in progress edit session
@@ -783,10 +763,7 @@ protected void RejectChanges()
             // Reject any child changes. Note, we must reject child changes before setting our own
             // state to Unmodified. This avoids a situation where we get notifications from child
             // entities that cause our state to flip back to Modified.
-            if (entitySet != null)
-            {
-                entitySet.EntityContainer.CompleteChildChanges(this, false);
-            }
+            entitySet?.EntityContainer.CompleteChildChanges(this, false);
 
             if (this._entityState == EntityState.Modified || this.Parent != null)
             {
@@ -830,10 +807,7 @@ protected void RejectChanges()
             UndoAllEntityActions();
 
             // Empty out the error collections
-            if (this._validationErrors != null)
-            {
-                this._validationErrors.Clear();
-            }
+            this._validationErrors?.Clear();
             this.EntityConflict = null;
             this._hasChildChanges = false;
             Debug.Assert(!this.HasChanges, "Entity.HasChanges should be false");
@@ -1845,7 +1819,7 @@ private EditSession(Entity entity)
             {
                 this._entity = entity;
                 this._lastState = entity.EntityState;
-                this._customMethodInvocations = entity._customMethodInvocations != null ? entity._customMethodInvocations.ToArray() : null;
+                this._customMethodInvocations = entity._customMethodInvocations?.ToArray();
                 this._validationErrors = entity.ValidationErrors.ToArray();
                 this._modifiedProperties = new List<string>();
             }