Spanify DynamicQueryable #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Daniel-Svensson
commented
Jan 25, 2024
src/OpenRiaServices.Hosting.Wcf/Framework/Linq/DynamicQueryable.cs
Outdated
Show resolved
Hide resolved
* use object.ReferenceEquals to be explicit about intent * rename token variable * set capacity in CreateKeywords
…update other dependencies
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current analyser suggestions/warnings when building AspNetCore hosting about several places in query deserialisation where span's should be used instead of substring.
Performance and allocations might be better, but the main driver is to remove build output when building the AspNetCore hosting project.
Apart from that it also changes naming of private fields to better match the rest of the code bases and uses "C#" names (such as
charinstead ofSystem.Char) and some usage of pattern matching (in their own commits)