Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AttachAsXXX methods to DbDomainService: #506

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Add AttachAsXXX methods to DbDomainService: #506

merged 4 commits into from
Jun 3, 2024

Conversation

SandstromErik
Copy link
Contributor

@SandstromErik SandstromErik commented May 13, 2024 •
edited by Daniel-Svensson
Loading

Add a new AttachAsModified method to DbDomainService (originally included AttachAsAdded, and AttachAsRemoved)

@Daniel-Svensson
Copy link
Member

Looks good, should we add overloads that don't take a dbset but use DbContext.Set<T>() instead? (And if so do we want to keep dbset parameter)?

@Daniel-Svensson Daniel-Svensson requested a review from a team May 13, 2024 15:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Daniel-Svensson Daniel-Svensson merged commit 3fc4bbf into OpenRIAServices:main Jun 3, 2024
5 checks passed
@Daniel-Svensson Daniel-Svensson added this to the 5.5.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel-Svensson Daniel-Svensson Daniel-Svensson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SandstromErik @Daniel-Svensson