Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc1 #24

Merged
merged 10 commits into from
Dec 12, 2024
Merged

Rc1 #24

merged 10 commits into from
Dec 12, 2024

Conversation

linxie47
Copy link
Contributor

No description provided.

linxie47 and others added 6 commits December 11, 2024 11:56
@linxie47
2024.12 rc1
d7422dc
@linxie47
Merge remote-tracking branch 'origin/master' into rc1
8eb408a
@linxie47
clean up
9c1f31e
@linxie47
sync more files
7e6898e
@linxie47
Add code owner
cc8c99a
@djie1 @linxie47
enable "-Wall" build flag; fix "-Wreorder" warnings. (#207)
7c968c1 
* enable "-Wall" build flag; fix "-Wreorder" warnings.

* fix "-Wsign-compare" warnings

* fix "-Wunused-but-set-variable" and "-Wunused-variable" warnings

* fix "-Wcatch-value=" warnings
@linxie47 linxie47 marked this pull request as ready for review December 11, 2024 13:04
xiaoxial
xiaoxial previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@xiaoxial xiaoxial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

djie1
djie1 reviewed Dec 12, 2024
View reviewed changes
.github/workflows/ubuntu-build-docker.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build_ivsr.sh Show resolved Hide resolved
ivsr_sdk/privates/model_guard.bin/libirguard.a-2024.4.0 Outdated Show resolved Hide resolved
djie1
djie1 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@djie1 djie1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linxie47 linxie47 merged commit 655573d into master Dec 12, 2024
4 checks passed
@linxie47 linxie47 deleted the rc1 branch December 12, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxial xiaoxial xiaoxial approved these changes

@djie1 djie1 djie1 approved these changes

@wangjingz wangjingz Awaiting requested review from wangjingz wangjingz is a code owner

@mnoiy mnoiy Awaiting requested review from mnoiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linxie47 @djie1 @xiaoxial