Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine build #26

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Refine build #26

merged 7 commits into from
Dec 17, 2024

Conversation

linxie47
Copy link
Contributor

No description provided.

@github-advanced-security
Copy link
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@linxie47 linxie47 marked this pull request as ready for review December 16, 2024 03:48
Copy link
Contributor

@djie1 djie1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

  1. do we still need "ivsr_setvar.sh" in section#2.3? If not, we can remove it. By the way, in Section#2.3/update contact info for model #2.4, it executes OpenVINO's setupvars.sh, not sure if the "LD_LIBRARY_PATH" setting is still required.
  2. in Section#2.3, we lose the option to "not" apply OpenVINO patches. This option was raised by Meta. But I kind of support your change, as v22.3 is one quite old version.

build.sh Show resolved Hide resolved
docs/docker_image_build.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@linxie47
Copy link
Contributor Author

Some comments:

  1. do we still need "ivsr_setvar.sh" in section#2.3? If not, we can remove it. By the way, in Section#2.3/update contact info for model #2.4, it executes OpenVINO's setupvars.sh, not sure if the "LD_LIBRARY_PATH" setting is still required.
  2. in Section#2.3, we lose the option to "not" apply OpenVINO patches. This option was raised by Meta. But I kind of support your change, as v22.3 is one quite old version.
  • Yes, will remove "ivsr_setvar.sh"
  • OpenVINO's setupvars.sh can cover all the env variables well. So don't need to set the "LD_LIBRARY_PATH" again.
  • Maintaining this option is a burden and looks ugly in my perspective, so remove it. Since the shell script is simple enough, customer can easily change it per their needs.

Copy link
Contributor

@djie1 djie1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiaoxial xiaoxial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linxie47 linxie47 merged commit 5308224 into master Dec 17, 2024
6 checks passed
@linxie47 linxie47 deleted the refine-build branch December 17, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants