Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches: Various additions and improvements #234

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Patches: Various additions and improvements #234

merged 6 commits into from
Nov 3, 2023

Conversation

CRASHARKI
Copy link
Contributor

Changes:

  • Add Widescreen patches to Taz Wanted to run the game at 16:9 Widescreen Aspect Ratio from the start.
  • Add Widescreen patches to Crash of the Titans to run the game at 16:9 Widescreen Aspect Ratio from the start.
  • Add Widescreen patches to Crash Mind Over Mutant to run the game at 16:9 Widescreen Aspect Ratio from the start.

All of the patches have been tested for all versions of the games, and relevant comments such as activating widescreen in-game or the need for EE Overclock have been added.

@kamfretoz
Copy link
Contributor

Since Crash Mind Over Mutant also has a built-in-game option for Progressive Scan, can you also make a patch that automatically enables it from the start? For completeness sake.

@CRASHARKI
Copy link
Contributor Author

I could try, but should I make it separated from the widescreen patch or part of the widescreen patch?

@CRASHARKI
Copy link
Contributor Author

Done, I added it as part of the Widescreen patch.

@refractionpcsx2
Copy link
Member

Please don't mix patches, make it a separate (but enablable) patch, since it's not the actual widescreen.

@CRASHARKI
Copy link
Contributor Author

Done, now it's a separate patch.

@kamfretoz
Copy link
Contributor

Maybe give the NTSC-U version some love too? 😁 (Mostly because it's the one i have xD)

@CRASHARKI
Copy link
Contributor Author

@kamfretoz What do you mean? the NTSC already runs at 60 FPS

@kamfretoz
Copy link
Contributor

@kamfretoz What do you mean? the NTSC already runs at 60 FPS

Sorry, i meant the Progressive Scan patch

@CRASHARKI
Copy link
Contributor Author

CRASHARKI commented Nov 3, 2023

@kamfretoz What do you mean? the NTSC already runs at 60 FPS

Sorry, i meant the Progressive Scan patch

I know, but what good does it do to the NTSC version? on PAL it changes the FPS limit from 50 to 60. I'm pretty sure I don't really know what progressive scan really is. I'll try to make a patch for the NTSC version, but could you tell me what it does?

Edit: NTSC-U patch done.

@refractionpcsx2
Copy link
Member

Done, now it's a separate patch.

thanks, one further question, what is the game speed like if it's forcing progressive 60fps on PAL? and all the physics. It's scary moving PAL games to 60fps.

@CRASHARKI
Copy link
Contributor Author

Done, now it's a separate patch.

thanks, one further question, what is the game speed like if it's forcing progressive 60fps on PAL? and all the physics. It's scary moving PAL games to 60fps.

The game actually has an in game option to enable Progressive Scan, this new patch just enables the option from the start. Also, playing the game at 50/60 FPS is achieved thanks to a patch that unlocks the framerate and is separate from the Progressive Scan patch.

@refractionpcsx2
Copy link
Member

Any why is it not nice to do that for the US version too? It'd be basically doing the same thing right?

@CRASHARKI
Copy link
Contributor Author

Any why is it not nice to do that for the US version too? It'd be basically doing the same thing right?

I just added that commit, but since neither the screen height or the FPS limit changes (unlike PAL version) I'm not sure if it's doing anything, but the game starts correctly. Is there anything I should notice when Progressive Scan is on?

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Nov 3, 2023

If you turn on the osd or the advanced status bar, it will tell you if it's progressive

It's possible we might be cheesing it anyway because we bypass the interlacing when in field mode.

@CRASHARKI
Copy link
Contributor Author

If you turn on the osd or the advanced status bar, it will tell you if it's progressive

It's possible we might be cheesing it anyway because we bypass the interlacing when in field mode.

The advance status bar seems to be working accurately, and indeed the NTSC-U patch is also working appropriately, so now everyone has Progressive Scan from the start. I already added it to the PR on this commit: c663f7e

@refractionpcsx2 refractionpcsx2 merged commit 9e613bb into PCSX2:main Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants