-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct reliance on PUF and CPS files: Stage 1 (PUF) #2538
base: master
Are you sure you want to change the base?
Conversation
Just a small note, the only change this will make to the Tax-Calculator API is that users will be required to specify the path to their Currently, if a user has the PUF file, a Records object would just be created as: recs = Records() Now, the user has to specify the 4 variables mentioned above: puf_data = 'puf_data.csv'
puf_weights = 'puf_weights.csv'
puf_ratios = 'puf_ratios.csv'
start_year = 2012
recs = Records(data=puf_data, weights=puf_weights, adjust_ratios=puf_ratios, start_year=start_year) |
The test suite has been updated. PUF data and related files have been replaced with synthetic data in tests. |
The CLI, docs for the CLI and recipes have been updated to support the new API. |
A script to generate random test data has been included to provide test data to replace the PUF. The generated data supplements data produced by validation set All tests are passing. AppVeyor is failing because the test data generation script is only run in the GH action. |
As a check, I'll test the TAXSIM32 suite using the new API/CLI once that PR is merged. |
The only failing test here is a difference between IndexError: positional indexers are out-of-bounds This might be related to a newly updated dependency either in taxcalc or paramtools affecting how |
This PR is the first in a pair of PRs that will remove Tax-Calculator's direct reliance on
puf.csv
andcps.csv
files. This PR focuses on all content regarding the PUF, and the next will focus on the CPS file.Each PR will be updated in stages: