Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend budget period from through 2034 to through 2074 #2755

Closed
wants to merge 27 commits into from

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jun 4, 2024

This thru74 branch can be merged into the master branch to create a version of Tax-Calculator that has a budget period that extends through 2074 (instead of through 2034).
This branch has not been merged because adding forty extra years to the budget period slows down Tax-Calculator significantly even when analyzing reforms during the standard ten-year budget period.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (a2622b9) to head (0b14676).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2755   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2619     2619           
=======================================
  Hits         2604     2604           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
taxcalc/policy.py 100.00% <100.00%> (ø)

@martinholmer martinholmer reopened this Jun 6, 2024
@jdebacker
Copy link
Member

@martinholmer Does this extrapolation only work with the TMD file? i.e., the PUF weights only going through 2034 mean that one cannot extrapolate the PUF file from TaxData to the years 2035+

BTW, I'm working on a PR to this branch that uses an update to ParamTools to allow the user to specify the budget window end year so only only needs to extrapolate parameters over the years they wish to use.

@martinholmer
Copy link
Collaborator Author

On the thru74 branch in Tax-Calculator PR #2755, @jdebacker asked:

Does this extrapolation only work with the TMD file? i.e., the PUF weights only going through 2034 mean that one cannot extrapolate the PUF file from TaxData to the years 2035+

The thru74 branch would work with the PUF dataset generated in the taxdata repo if the PUF weights extended through 2074 and the PUF grow factors extended thru 2074.

@martinholmer martinholmer removed the WIP label Dec 18, 2024
@martinholmer
Copy link
Collaborator Author

PR #2755 (the thru74 branch) is being closed because PR #2856 makes it obsolete.

@martinholmer martinholmer deleted the thru74 branch December 18, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants