Bug fixes

PaoloCuscela · Aug 22, 2018 · 9b8e160 · 9b8e160
1 parent 767fb19
commit 9b8e160
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 31 deletions.
diff --git a/Cards.podspec b/Cards.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'Cards'
-  s.version          = '1.3.1'
+  s.version          = '1.3.4'
   s.summary          = 'Awesome iOS 11 appstore cards in swift 4.'
   s.homepage         = 'https://github.com/PaoloCuscela/Cards'
   s.screenshots      = 'https://raw.githubusercontent.com/PaoloCuscela/Cards/master/Images/Header.png', 'https://raw.githubusercontent.com/PaoloCuscela/Cards/master/Images/DetailView.gif'

diff --git a/Cards/Sources/DetailViewController.swift b/Cards/Sources/DetailViewController.swift
@@ -136,7 +136,7 @@ internal class DetailViewController: UIViewController {
 
         // Layout for present in non-fullscreen
         } else {
-            scrollView.frame.size = CGSize(width: LayoutHelper.XScreen(85), height: LayoutHelper.YScreen(100) - 20)
+            scrollView.frame.size = CGSize(width: LayoutHelper.YScreen(90), height: LayoutHelper.XScreen(100) - 20)
             scrollView.center = blurView.center
             scrollView.frame.origin.y = 40
         }

diff --git a/Cards/Sources/LayoutHelper.swift b/Cards/Sources/LayoutHelper.swift
@@ -55,20 +55,16 @@ open class LayoutHelper {
 
     static open func XScreen(_ percentage: CGFloat) -> CGFloat {
 
-        if UIDevice.current.orientation == .landscapeLeft || UIDevice.current.orientation == .landscapeRight {
+
             return percentage * UIScreen.main.bounds.height / 100
-        } else {
-            return percentage * UIScreen.main.bounds.width / 100
-        }
+
     }
 
     static open func YScreen(_ percentage: CGFloat) -> CGFloat {
 
-        if UIDevice.current.orientation == .landscapeLeft || UIDevice.current.orientation == .landscapeRight {
+
             return percentage * UIScreen.main.bounds.width / 100
-        } else {
-            return percentage * UIScreen.main.bounds.height / 100
-        }
+
     }
 
 }

diff --git a/Demo/Demo.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist b/Demo/Demo.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>IDEDidComputeMac32BitWarning</key>
+	<true/>
+</dict>
+</plist>
diff --git a/...Demo.xcworkspace/xcuserdata/paolocuscela.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist b/...Demo.xcworkspace/xcuserdata/paolocuscela.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist
@@ -90,7 +90,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/Card.swift"
-            timestampString = "555085162.8374161"
+            timestampString = "555086835.8593301"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "149"
@@ -186,7 +186,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/Card.swift"
-            timestampString = "555085162.8375469"
+            timestampString = "555086835.85947"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "187"
@@ -234,7 +234,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/Card.swift"
-            timestampString = "555085162.837618"
+            timestampString = "555086835.859544"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "186"
@@ -378,7 +378,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/Card.swift"
-            timestampString = "555085162.837718"
+            timestampString = "555086835.8596489"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "192"
@@ -490,7 +490,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/Card.swift"
-            timestampString = "555085162.837816"
+            timestampString = "555086835.859755"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "245"
@@ -600,13 +600,13 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "Demo/ViewControllers/HighlightViewController.swift"
-            timestampString = "555085162.837919"
+            timestampString = "555086835.85987"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "61"
             endingLineNumber = "61"
-            landmarkName = "cardHighlightDidTapButton(card:button:)"
-            landmarkType = "7">
+            landmarkName = "HighlightViewController"
+            landmarkType = "21">
          </BreakpointContent>
       </BreakpointProxy>
       <BreakpointProxy
@@ -648,7 +648,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "Demo/ViewControllers/HighlightViewController.swift"
-            timestampString = "555085162.838006"
+            timestampString = "555086835.8599581"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "55"
@@ -664,13 +664,13 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "Demo/ViewControllers/HighlightViewController.swift"
-            timestampString = "555085162.838056"
+            timestampString = "555086835.860009"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "51"
             endingLineNumber = "51"
-            landmarkName = "cardDidTapInside(card:)"
-            landmarkType = "7">
+            landmarkName = "HighlightViewController"
+            landmarkType = "21">
          </BreakpointContent>
       </BreakpointProxy>
       <BreakpointProxy
@@ -728,7 +728,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/Animator.swift"
-            timestampString = "555085162.838154"
+            timestampString = "556634741.750271"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "93"
@@ -744,7 +744,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/DetailViewController.swift"
-            timestampString = "555085162.838212"
+            timestampString = "556634741.7506551"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "133"
@@ -760,7 +760,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/DetailViewController.swift"
-            timestampString = "555085162.8387049"
+            timestampString = "556634741.750713"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "86"
@@ -776,7 +776,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/DetailViewController.swift"
-            timestampString = "555085162.839045"
+            timestampString = "556634741.750765"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "211"
@@ -792,7 +792,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/DetailViewController.swift"
-            timestampString = "555085162.839378"
+            timestampString = "556634741.7508169"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "240"
@@ -808,7 +808,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/DetailViewController.swift"
-            timestampString = "555085162.839703"
+            timestampString = "556634741.750869"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "126"
@@ -824,7 +824,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/DetailViewController.swift"
-            timestampString = "555085162.839972"
+            timestampString = "556634741.750922"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "146"
@@ -840,7 +840,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/Animator.swift"
-            timestampString = "555085162.840239"
+            timestampString = "556634741.7509741"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "100"
@@ -856,7 +856,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "../Cards/Sources/DetailViewController.swift"
-            timestampString = "555085162.840292"
+            timestampString = "556634741.751207"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "205"