Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add reaction constants #182

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

megum1n
Copy link
Contributor

@megum1n megum1n commented Jul 18, 2024

What

Just like in #179, it would be great to have constants for all available reactions.
I've added new dependency to get reaction name from the emoji string.

Alternatives

  • Find JSON with all emojis somewhere on github, which has a map with emoji labels. Scrub trough it to find names for emojis
  • Generate such file ourselves via scrape script in https://github.com/PaulSonOfLars/telegram-bot-api-spec
  • There might be an easier way to do that w/o additional dependencies, but I couldn't find it 😓

Impact

  • Are your changes backwards compatible? Y
  • Have you included documentation, or updated existing documentation? Y
  • Do errors and log messages provide enough context? N/A

@megum1n megum1n changed the title Add emoji constants Add reaction constants Jul 18, 2024
@annihilatorrrr
Copy link

Maybe: https://github.com/PaulSonOfLars/gotgbot#features

No third party library bloat; only uses standard library.

@megum1n megum1n changed the title Add reaction constants Draft: Add reaction constants Jul 19, 2024
@megum1n
Copy link
Contributor Author

megum1n commented Jul 19, 2024

@annihilatorrrr

No third party library bloat; only uses standard library.

gotgbot package itself still won't use any bloat. Only script to generate code will use external package.

@PaulSonOfLars
Copy link
Owner

PaulSonOfLars commented Jul 31, 2024

Hey, thank you for your patience on my reply.

I know what you mean by thi not adding dependencies in practice, but it is in the root go.mod file, so there is a questionmark there. Would be best if they weren't there...

One option would be to make the generation files their own module; could we try creating some new go.mod and go.sum files for the codegen only? That should allow us to separate things as needed, and keep the lib dependency-free :)

@liuerfire
Copy link
Contributor

liuerfire commented Aug 22, 2024

How about make another repo for plugins or handlers need extra deps like python-telegram-bot has ptbcontrib?

@PaulSonOfLars
Copy link
Owner

@liuerfire That is indeed something I've considered.

Happy to open one up if theres demand :)
What kind of things would people be looking for?

  • emoji constants
  • logging tools?
  • Rate limit wrappers? That kind of thing?

@liuerfire
Copy link
Contributor

the most I want is persistent states for conversation :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants