Move responsibility of select's value attribute to PhpGt/Dom (#319)

* feature: implement select value binding closes #317 * stan: improve lvl 6 checks * build: bump dependencies * stan: fix option class * tweak: handle value attribute specifically * stan: handle value property
PhpGt · Jan 30, 2022 · d8ea73c · d8ea73c
1 parent 822e7b3
commit d8ea73c
Show file tree

Hide file tree

Showing 4 changed files with 57 additions and 44 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/DocumentBinder.php b/src/DocumentBinder.php
@@ -16,6 +16,7 @@ class DocumentBinder {
 
 	/**
 	 * @param array<string, string> $config
+	 * @noinspection PhpPropertyOnlyWrittenInspection
 	 */
 	public function __construct(
 		private Document $document,

diff --git a/src/HTMLAttributeBinder.php b/src/HTMLAttributeBinder.php
@@ -173,6 +173,10 @@ private function setBindProperty(
 			$this->tableBinder->bindTableData($bindValue, $element);
 			break;
 
+		case "value":
+			$element->value = $bindValue; /** @phpstan-ignore-line  */
+			break;
+
 		default:
 			if($modifier) {
 				$this->handleModifier(

diff --git a/src/PlaceholderText.php b/src/PlaceholderText.php
@@ -1,12 +1,12 @@
-<?php
+<?php /** @noinspection PhpPropertyOnlyWrittenInspection tracked in issue #290 */
 namespace Gt\DomTemplate;
 
 use Gt\Dom\Element;
 use Gt\Dom\Text;
 
 class PlaceholderText {
 	private string $bindKey;
-	private ?string $default; /** @phpstan-ignore-line tracked in issue #290 */
+	private ?string $default; /** @phpstan-ignore-line */
 
 	public function __construct(
 		private Text $originalText