Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 dev → main #344

Merged
merged 10 commits into from
Jul 2, 2024

Merge pull request #343 from Police-Data-Accessibility-Project/malfor…

6622599
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

v1 dev → main #344

Merge pull request #343 from Police-Data-Accessibility-Project/malfor…
6622599
Select commit
Loading
Failed to load commit list.
GitHub Actions / flake8 completed Jul 1, 2024 in 1s

reviewdog [flake8] report

reported by reviewdog 🐶

Findings (2)

regular_api_checks.py|98 col 1| Missing docstring in public function
regular_api_checks.py|102 col 80| line too long (82 > 79 characters)

Filtered Findings (431)

app.py|1 col 1| Missing docstring in public module
app.py|23 col 80| line too long (84 > 79 characters)
app.py|26 col 1| Missing docstring in public function
app.py|30 col 1| Missing docstring in public function
app.py|57 col 80| line too long (86 > 79 characters)
app_test.py|1 col 1| Missing docstring in public module
app_test.py|4 col 1| 'flask_restful.Api' imported but unused
app_test.py|51 col 1| redefinition of unused 'pytest' from line 1
app_test.py|52 col 1| 'resources.ApiKey.ApiKey' imported but unused
app_test.py|55 col 1| 'werkzeug.security.check_password_hash' imported but unused
app_test.py|65 col 1| Missing docstring in public function
app_test.py|71 col 1| Missing docstring in public function
app_test.py|76 col 1| Missing docstring in public function
app_test.py|81 col 1| Missing docstring in public function
app_test.py|82 col 80| line too long (81 > 79 characters)
app_test.py|98 col 1| Missing docstring in public function
app_test.py|104 col 1| Missing docstring in public function
app_test.py|110 col 1| Missing docstring in public function
app_test.py|124 col 80| line too long (86 > 79 characters)
app_test.py|126 col 80| line too long (103 > 79 characters)
app_test.py|133 col 80| line too long (82 > 79 characters)
app_test.py|135 col 80| line too long (215 > 79 characters)
app_test.py|143 col 1| Missing docstring in public function
app_test.py|149 col 1| Missing docstring in public function
app_test.py|155 col 1| Missing docstring in public function
app_test.py|161 col 1| Missing docstring in public function
app_test.py|165 col 80| line too long (87 > 79 characters)
app_test.py|170 col 1| Missing docstring in public function
app_test.py|178 col 1| Missing docstring in public function
app_test.py|186 col 1| Missing docstring in public function
app_test.py|186 col 1| redefinition of unused 'test_data_sources' from line 149
app_test.py|192 col 1| Missing docstring in public function
app_test.py|197 col 9| f-string is missing placeholders
app_test.py|203 col 1| Missing docstring in public function
app_test.py|210 col 1| Missing docstring in public function
app_test.py|220 col 1| Missing docstring in public function
app_test.py|227 col 1| Missing docstring in public function
app_test.py|234 col 1| Missing docstring in public function
app_test.py|242 col 1| Missing docstring in public function
app_test.py|250 col 1| Missing docstring in public function
app_test.py|255 col 9| f-string is missing placeholders
app_test.py|261 col 1| Missing docstring in public function
app_test.py|266 col 9| f-string is missing placeholders
app_test.py|272 col 1| Missing docstring in public function
app_test.py|278 col 1| Missing docstring in public function
app_test.py|287 col 9| f-string is missing placeholders
app_test.py|287 col 80| line too long (113 > 79 characters)
app_test.py|294 col 1| Missing docstring in public function
app_test.py|300 col 9| f-string is missing placeholders
app_test.py|300 col 80| line too long (88 > 79 characters)
app_test.py|307 col 1| Missing docstring in public function
app_test.py|313 col 12| do not compare types, for exact checks use is / is not, for instance checks use isinstance()
app_test.py|317 col 1| Missing docstring in public function
app_test.py|318 col 80| line too long (88 > 79 characters)
app_test.py|320 col 80| line too long (80 > 79 characters)
app_test.py|323 col 1| Missing docstring in public function
app_test.py|346 col 1| Missing docstring in public function
app_test.py|406 col 1| Missing docstring in public function
app_test.py|420 col 80| line too long (80 > 79 characters)
app_test_data.py|1 col 1| Missing docstring in public module
app_test_data.py|32 col 80| line too long (81 > 79 characters)
app_test_data.py|33 col 80| line too long (80 > 79 characters)
app_test_data.py|37 col 80| line too long (103 > 79 characters)
app_test_data.py|58 col 80| line too long (377 > 79 characters)
app_test_data.py|60 col 80| line too long (89 > 79 characters)
app_test_data.py|83 col 80| line too long (81 > 79 characters)
app_test_data.py|84 col 80| line too long (80 > 79 characters)
app_test_data.py|88 col 80| line too long (103 > 79 characters)
app_test_data.py|134 col 80| line too long (82 > 79 characters)
app_test_data.py|135 col 80| line too long (80 > 79 characters)
app_test_data.py|139 col 80| line too long (103 > 79 characters)
app_test_data.py|185 col 80| line too long (81 > 79 characters)
app_test_data.py|186 col 80| line too long (80 > 79 characters)
app_test_data.py|189 col 80| line too long (103 > 79 characters)
app_test_data.py|203 col 80| line too long (81 > 79 characters)
app_test_data.py|228 col 80| line too long (81 > 79 characters)
app_test_data.py|229 col 80| line too long (80 > 79 characters)
app_test_data.py|232 col 80| line too long (103 > 79 characters)
app_test_data.py|251 col 80| line too long (111 > 79 characters)
app_test_data.py|270 col 80| line too long (103 > 79 characters)
app_test_data.py|276 col 80| line too long (99 > 79 characters)
app_test_data.py|300 col 80| line too long (385 > 79 characters)
app_test_data.py|306 col 80| line too long (99 > 79 characters)
app_test_data.py|333 col 80| line too long (377 > 79 characters)
app_test_data.py|335 col 80| line too long (89 > 79 characters)
app_test_data.py|364 col 80| line too long (473 > 79 characters)
app_test_data.py|366 col 80| line too long (80 > 79 characters)
app_test_data.py|370 col 80| line too long (103 > 79 characters)
app_test_data.py|372 col 80| line too long (80 > 79 characters)
app_test_data.py|392 col 80| line too long (1082 > 79 characters)
app_test_data.py|398 col 80| line too long (103 > 79 characters)
app_test_data.py|400 col 80| line too long (81 > 79 characters)
app_test_data.py|420 col 80| line too long (431 > 79 characters)
app_test_data.py|422 col 80| line too long (80 > 79 characters)
app_test_data.py|426 col 80| line too long (103 > 79 characters)
app_test_data.py|428 col 80| line too long (81 > 79 characters)
gunicorn_config.py|1 col 1| Missing docstring in public module
middleware/init.py|1 col 1| Missing docstring in public package
middleware/archives_queries.py|1 col 1| Missing docstring in public module
middleware/archives_queries.py|1 col 1| 'typing.Tuple' imported but unused
middleware/archives_queries.py|15 col 1| First line should end with a period
middleware/archives_queries.py|15 col 1| First line should be in imperative mood
middleware/archives_queries.py|19 col 80| line too long (88 > 79 characters)
middleware/archives_queries.py|31 col 10| trailing whitespace
middleware/archives_queries.py|32 col 80| line too long (151 > 79 characters)
middleware/archives_queries.py|43 col 1| First line should be in imperative mood
middleware/archives_queries.py|44 col 80| line too long (130 > 79 characters)
middleware/archives_queries.py|46 col 80| line too long (94 > 79 characters)
middleware/archives_queries.py|48 col 80| line too long (96 > 79 characters)
middleware/archives_queries.py|51 col 80| line too long (84 > 79 characters)
middleware/archives_queries.py|66 col 1| First line should be in imperative mood
middleware/archives_queries.py|67 col 80| line too long (85 > 79 characters)
middleware/archives_queries.py|75 col 80| line too long (144 > 79 characters)
middleware/archives_queries.py|83 col 1| First line should be in imperative mood
middleware/archives_queries.py|91 col 80| line too long (88 > 79 characters)
middleware/archives_queries.py|102 col 1| First line should be in imperative mood
middleware/archives_queries.py|103 col 80| line too long (128 > 79 characters)
middleware/archives_queries.py|106 col 80| line too long (90 > 79 characters)
middleware/data_source_queries.py|1 col 1| Missing docstring in public module
middleware/data_source_queries.py|1 col 1| 'typing.Tuple' imported but unused
middleware/data_source_queries.py|79 col 1| First line should be in imperative mood
middleware/data_source_queries.py|80 col 80| line too long (109 > 79 characters)
middleware/data_source_queries.py|84 col 80| line too long (84 > 79 characters)
middleware/data_source_queries.py|95 col 80| line too long (83 > 79 characters)
middleware/data_source_queries.py|107 col 80| line too long (87 > 79 characters)
middleware/data_source_queries.py|109 col 80| line too long (94 > 79 characters)
middleware/data_source_queries.py|111 col 80| line too long (91 > 79 characters)
middleware/data_source_queries.py|128 col 1| First line should be in imperative mood
middleware/data_source_queries.py|129 col 80| line too long (110 > 79 characters)
middleware/data_source_queries.py|132 col 80| line too long (99 > 79 characters)
middleware/data_source_queries.py|159 col 1| First line should be in imperative mood
middleware/data_source_queries.py|160 col 80| line too long (102 > 79 characters)
middleware/data_source_queries.py|163 col 80| line too long (101 > 79 characters)
middleware/data_source_queries.py|180 col 80| line too long (87 > 79 characters)
middleware/data_source_queries.py|182 col 80| line too long (94 > 79 characters)
middleware/data_source_queries.py|196 col 1| One-line docstring should fit on one line with quotes
middleware/data_source_queries.py|196 col 1| First line should end with a period
middleware/data_source_queries.py|196 col 1| First line should be in imperative mood
middleware/data_source_queries.py|220 col 1| One-line docstring should fit on one line with quotes
middleware/data_source_queries.py|220 col 1| First line should end with a period
middleware/data_source_queries.py|220 col 1| First line should be in imperative mood
middleware/data_source_queries.py|239 col 80| line too long (87 > 79 characters)
middleware/data_source_queries.py|241 col 80| line too long (94 > 79 characters)
middleware/data_source_queries.py|258 col 1| First line should be in imperative mood
middleware/data_source_queries.py|259 col 80| line too long (100 > 79 characters)
middleware/data_source_queries.py|263 col 80| line too long (107 > 79 characters)
middleware/data_source_queries.py|264 col 80| line too long (108 > 79 characters)
middleware/data_source_queries.py|276 col 80| line too long (84 > 79 characters)
middleware/homepage_search_cache.py|1 col 1| Missing docstring in public module
middleware/homepage_search_cache.py|17 col 10| trailing whitespace
middleware/homepage_search_cache.py|22 col 80| line too long (99 > 79 characters)
middleware/homepage_search_cache.py|35 col 1| Missing docstring in public function
middleware/homepage_search_cache.py|35 col 80| line too long (87 > 79 characters)
middleware/homepage_search_cache.py|45 col 1| Missing docstring in public function
middleware/homepage_search_cache.py|46 col 80| line too long (82 > 79 characters)
middleware/initialize_psycopg2_connection.py|1 col 1| Missing docstring in public module
middleware/initialize_psycopg2_connection.py|11 col 1| 1 blank line required between summary line and description
middleware/initialize_psycopg2_connection.py|11 col 1| First line should end with a period
middleware/initialize_psycopg2_connection.py|11 col 1| First line should be in imperative mood
middleware/initialize_psycopg2_connection.py|12 col 80| line too long (95 > 79 characters)
middleware/initialize_psycopg2_connection.py|13 col 80| line too long (99 > 79 characters)
middleware/initialize_psycopg2_connection.py|16 col 80| line too long (106 > 79 characters)
middleware/initialize_psycopg2_connection.py|18 col 80| line too long (127 > 79 characters)
middleware/initialize_psycopg2_connection.py|32 col 5| do not use bare 'except'
middleware/initialize_psycopg2_connection.py|33 col 80| line too long (80 > 79 characters)
middleware/login_queries.py|1 col 1| Missing docstring in public module
middleware/login_queries.py|9 col 1| First line should be in imperative mood
middleware/login_queries.py|17 col 80| line too long (81 > 79 characters)
middleware/login_queries.py|32 col 1| First line should be in imperative mood
middleware/login_queries.py|52 col 1| First line should be in imperative mood
middleware/login_queries.py|53 col 80| line too long (86 > 79 characters)
middleware/login_queries.py|60 col 80| line too long (85 > 79 characters)
middleware/login_queries.py|66 col 80| line too long (83 > 79 characters)
middleware/login_queries.py|68 col 80| line too long (123 > 79 characters)
middleware/login_queries.py|75 col 1| First line should be in imperative mood
middleware/login_queries.py|82 col 80| line too long (83 > 79 characters)
middleware/quick_search_query.py|1 col 1| Missing docstring in public module
middleware/quick_search_query.py|40 col 80| line too long (83 > 79 characters)
middleware/quick_search_query.py|42 col 80| line too long (90 > 79 characters)
middleware/quick_search_query.py|46 col 80| line too long (156 > 79 characters)
middleware/quick_search_query.py|46 col 157| trailing whitespace
middleware/quick_search_query.py|47 col 80| line too long (137 > 79 characters)
middleware/quick_search_query.py|47 col 138| trailing whitespace
middleware/quick_search_query.py|48 col 80| line too long (164 > 79 characters)
middleware/quick_search_query.py|48 col 165| trailing whitespace
middleware/quick_search_query.py|49 col 80| line too long (81 > 79 characters)
middleware/quick_search_query.py|55 col 80| line too long (181 > 79 characters)
middleware/quick_search_query.py|61 col 1| First line should be in imperative mood
middleware/quick_search_query.py|62 col 80| line too long (81 > 79 characters)
middleware/quick_search_query.py|79 col 1| First line should be in imperative mood
middleware/quick_search_query.py|80 col 80| line too long (109 > 79 characters)
middleware/quick_search_query.py|98 col 80| line too long (83 > 79 characters)
middleware/quick_search_query.py|112 col 1| First line should be in imperative mood
middleware/quick_search_query.py|113 col 80| line too long (117 > 79 characters)
middleware/quick_search_query.py|119 col 80| line too long (88 > 79 characters)
middleware/quick_search_query.py|123 col 8| do not compare types, for exact checks use is / is not, for instance checks use isinstance()
middleware/quick_search_query.py|143 col 80| line too long (100 > 79 characters)
middleware/quick_search_query.py|171 col 80| line too long (87 > 79 characters)
middleware/reset_token_queries.py|1 col 1| Missing docstring in public module
middleware/reset_token_queries.py|5 col 80| line too long (82 > 79 characters)
middleware/reset_token_queries.py|6 col 1| First line should be in imperative mood
middleware/reset_token_queries.py|7 col 80| line too long (90 > 79 characters)
middleware/reset_token_queries.py|11 col 80| line too long (132 > 79 characters)
middleware/reset_token_queries.py|14 col 80| line too long (82 > 79 characters)
middleware/reset_token_queries.py|29 col 1| First line should be in imperative mood
middleware/reset_token_queries.py|37 col 80| line too long (80 > 79 characters)
middleware/reset_token_queries.py|44 col 1| First line should be in imperative mood
middleware/reset_token_queries.py|52 col 80| line too long (81 > 79 characters)
middleware/security.py|1 col 1| Missing docstring in public module
middleware/security.py|2 col 1| 'hmac.compare_digest' imported but unused
middleware/security.py|3 col 1| 'flask.jsonify' imported but unused
middleware/security.py|4 col 80| line too long (84 > 79 characters)
middleware/security.py|7 col 1| 'os' imported but unused
middleware/security.py|9 col 1| 'flask.wrappers.Response' imported but unused
middleware/security.py|10 col 1| 'psycopg2.extensions.cursor as PgCursor' imported but unused
middleware/security.py|14 col 1| First line should be in imperative mood
middleware/security.py|15 col 80| line too long (101 > 79 characters)
middleware/security.py|20 col 80| line too long (98 > 79 characters)
middleware/security.py|27 col 80| line too long (86 > 79 characters)
middleware/security.py|34 col 80| line too long (90 > 79 characters)
middleware/security.py|49 col 80| line too long (88 > 79 characters)
middleware/security.py|52 col 80| line too long (80 > 79 characters)
middleware/security.py|60 col 80| line too long (83 > 79 characters)
middleware/security.py|64 col 80| line too long (88 > 79 characters)
middleware/security.py|65 col 80| line too long (92 > 79 characters)
middleware/security.py|71 col 1| 1 blank line required between summary line and description
middleware/security.py|71 col 1| First line should end with a period
middleware/security.py|71 col 1| First line should be in imperative mood; try rephrasing
middleware/security.py|72 col 80| line too long (122 > 79 characters)
middleware/security.py|73 col 80| line too long (93 > 79 characters)
middleware/security.py|74 col 80| line too long (127 > 79 characters)
middleware/security.py|83 col 80| line too long (86 > 79 characters)
middleware/security.py|89 col 80| line too long (93 > 79 characters)
middleware/security.py|93 col 80| line too long (88 > 79 characters)
middleware/user_queries.py|1 col 1| Missing docstring in public module
middleware/user_queries.py|7 col 1| First line should be in imperative mood
middleware/user_queries.py|12 col 80| line too long (82 > 79 characters)
middleware/user_queries.py|24 col 1| First line should be in imperative mood
middleware/user_queries.py|33 col 80| line too long (93 > 79 characters)
regular_api_checks.py|1 col 1| Missing docstring in public module
regular_api_checks.py|12 col 1| Missing docstring in public function
regular_api_checks.py|22 col 1| Missing docstring in public function
regular_api_checks.py|22 col 80| line too long (81 > 79 characters)
regular_api_checks.py|32 col 1| Missing docstring in public function
regular_api_checks.py|34 col 80| line too long (82 > 79 characters)
regular_api_checks.py|42 col 1| Missing docstring in public function
regular_api_checks.py|52 col 1| Missing docstring in public function
regular_api_checks.py|62 col 1| Missing docstring in public function
regular_api_checks.py|73 col 1| Missing docstring in public function
regular_api_checks.py|82 col 1| Missing docstring in public function
regular_api_checks.py|88 col 1| Missing docstring in public function
regular_api_checks.py|108 col 1| Missing docstring in public function
regular_api_checks.py|118 col 1| Missing docstring in public function
regular_api_checks.py|123 col 80| line too long (86 > 79 characters)
regular_api_checks.py|128 col 1| Missing docstring in public function
regular_api_checks.py|137 col 1| Missing docstring in public function
regular_api_checks.py|144 col 1| Missing docstring in public function
regular_api_checks.py|150 col 1| Missing docstring in public function
regular_api_checks.py|152 col 80| line too long (86 > 79 characters)
regular_api_checks.py|158 col 1| Missing docstring in public function
regular_api_checks.py|160 col 80| line too long (89 > 79 characters)
regular_api_checks.py|168 col 1| Missing docstring in public function
regular_api_checks.py|179 col 1| Missing docstring in public function
regular_api_checks.py|189 col 1| Missing docstring in public function
regular_api_checks.py|204 col 1| Missing docstring in public function
regular_api_checks.py|220 col 1| Missing docstring in public function
regular_api_checks.py|237 col 1| Missing docstring in public function
regular_api_checks.py|248 col 1| Missing docstring in public function
regular_api_checks.py|254 col 1| Missing docstring in public function
regular_api_checks.py|272 col 1| Missing docstring in public function
regular_api_checks.py|291 col 1| Missing docstring in public function
regular_api_checks.py|297 col 1| Missing docstring in public function
regular_api_checks.py|304 col 1| Missing docstring in public function
regular_api_checks.py|307 col 80| line too long (85 > 79 characters)
regular_api_checks.py|308 col 80| line too long (82 > 79 characters)
regular_api_checks.py|337 col 30| comparison to True should be 'if cond is True:' or 'if cond:'
resources/Agencies.py|1 col 1| Missing docstring in public module
resources/Agencies.py|37 col 80| line too long (84 > 79 characters)
resources/Agencies.py|41 col 1| First line should be in imperative mood
resources/Agencies.py|48 col 80| line too long (86 > 79 characters)
resources/Agencies.py|55 col 80| line too long (112 > 79 characters)
resources/Agencies.py|65 col 80| line too long (81 > 79 characters)
resources/ApiKey.py|1 col 1| Missing docstring in public module
resources/ApiKey.py|11 col 80| line too long (82 > 79 characters)
resources/ApiKey.py|14 col 1| First line should be in imperative mood
resources/ApiKey.py|15 col 80| line too long (84 > 79 characters)
resources/ApiKey.py|17 col 80| line too long (95 > 79 characters)
resources/ApiKey.py|21 col 80| line too long (90 > 79 characters)
resources/ApiKey.py|34 col 80| line too long (85 > 79 characters)
resources/Archives.py|1 col 1| Missing docstring in public module
resources/Archives.py|12 col 1| One-line docstring should fit on one line with quotes
resources/Archives.py|13 col 80| line too long (97 > 79 characters)
resources/Archives.py|18 col 1| First line should be in imperative mood
resources/Archives.py|21 col 80| line too long (102 > 79 characters)
resources/Archives.py|24 col 80| line too long (124 > 79 characters)
resources/Archives.py|40 col 1| First line should be in imperative mood
... (Too many findings. Dropped some findings)

Annotations

Check warning on line 98 in regular_api_checks.py

See this annotation in the file changed.

@github-actions github-actions / flake8

[flake8] regular_api_checks.py#L98 <103>

Missing docstring in public function
Raw output
./regular_api_checks.py:98:1: D103 Missing docstring in public function

Check failure on line 102 in regular_api_checks.py

See this annotation in the file changed.

@github-actions github-actions / flake8

[flake8] regular_api_checks.py#L102 <501>

line too long (82 > 79 characters)
Raw output
./regular_api_checks.py:102:80: E501 line too long (82 > 79 characters)