Re-enable cliff impacts #2211
Merged
Re-enable cliff impacts #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilwoodruff
approved these changes
Nov 19, 2024
|
Good to go now |
|
What does it say the baseline cliff rate and gap are, by CPS and ECPS? |
|
At the moment, we don't actually permit the running of baseline sims, and thus I cannot run the cliff impacts, either. Is there another policy we can use? Alternatively: should we be enabling baseline runs? |
|
Just hover over the bar chart |
|
Here are screenshots of the requested four outputs: |
|
This is using the MTR-based definition and a delta of $1,000 |
|
Thanks. For posterity (data for 2024):
|
MaxGhenis
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1843. To not crash, this requires the merging of PolicyEngine/policyengine-api#1982; to correctly calculate UK results, PolicyEngine/policyengine-uk#997 must also be merged. This PR will remain in draft until the merging of the relevant API changes and until I can capture some screenshots.
Changes
Re-enables cliff impacts. Also removes a hanging semicolon that created a floating semicolon on the cliff impacts output page. Most of this code merely un-comments code that was previously commented out as a result of #1099.
Screenshots
Tests
N/A