Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update policyengine-core and method for determining microsimulation #940

Closed
wants to merge 5 commits into from

Conversation

MaxGhenis
Copy link
Collaborator

Fix #939

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PavelMakarchuk
Copy link
Collaborator

LGTM

The test failure seems to be due to the missing dataset

@MaxGhenis
Copy link
Collaborator Author

Oops forgot we can't test from forks. Filed #941.

@MaxGhenis MaxGhenis closed this Sep 3, 2024
@MaxGhenis MaxGhenis deleted the MaxGhenis/issue939 branch September 3, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace if hasattr(person.simulation, "dataset"): with if person.simulation.dataset is not None:
2 participants