Modernize project with latest versions of Python & Django #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard against issues with a non-empty default QuerySet returned by a Model's Manager instance by calling the Model's _base_manager when doing lookups by dn. LDAP lookups by dn must be done by setting the dn as the base of the LDAP query. The current method for determining if a dn lookup is being requested relies on inspecting the generated django.db.models.sql.query.Query and looking for a 'dn' target column in the first where clause statement. If a Model uses a custom Manager to append a where clause statement to all QuerySets, this logic is broken. Using _base_manager instead of objects as the Manager for constructing explicit dn lookups avoids this problem. This behavior also matches the Django documentation and internals for related object access, so it is likely to continue to work for the foreseeable future. Fixes django-ldapdb#196
No changes in ths commit
Openldap's backend changed from hdb (2.4) to mdb (2.5).
Setting default value changes from False (Django 3.2) to True (Django 4.0). Setting deprecated in Django 4.0
alias deprecated in Django 4.1
sandre35
force-pushed
the
sandre/modernize
branch
from
0b784e5 to
9362672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.