auth: added self weighted lua function

[n0tlu5]

Short description

added a new Lua function that returns pickwhashed or pickrandom(if there is no available candidate) but the weight is fetched from candidates via URL. Modified some functions to be able to provide weight as a state.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• documented the code
• added or modified regression test(s)
• included documentation (including possible behaviour changes)
• added or modified unit test(s)
• checked that this code was merged to master

[coveralls]

Pull Request Test Coverage Report for Build 12544460123

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 45 (0.0%) changed or added relevant lines in 1 file are covered.
• 11254 unchanged lines in 158 files lost coverage.
• Overall coverage increased (+9.4%) to 73.952%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/lua-record.cc	0	45	0.0%

Files with Coverage Reduction	New Missed Lines	%
pdns/dnsdistdist/dnsdist-session-cache.cc	1	62.86%
pdns/dns.hh	1	75.0%
pdns/dnspacket.hh	1	94.44%
modules/gpgsqlbackend/gpgsqlbackend.cc	1	88.62%
pdns/dnsdistdist/test-dnsdistrules_cc.cc	1	95.15%
pdns/dnsdistdist/test-dnsdistnghttp2-in_cc.cc	1	85.12%
pdns/recursordist/rec-main.hh	1	83.17%
pdns/backends/gsql/gsqlbackend.hh	1	97.71%
ext/lmdb-safe/lmdb-typed.cc	1	89.66%
pdns/dnsdistdist/dnsdist-lbpolicies.hh	1	64.29%

Totals
Change from base Build 9198989085:	9.4%
Covered Lines:	47587
Relevant Lines:	61249

---

💛 - Coveralls

[Habbie]

lua-record.cc:229:20: error: use of undeclared identifier 'd_lock' - are you sure you compiled the version you PRed here?

given the age of this PR (sorry) it might have been from the merge, of course. Can you rebase and test? Thank you!

[Habbie]

this makes sense at a quick glance. It'll need a minor rework because we changed how locking works. Can you add docs?

I'm unsure about the name selfweighted but that's a small detail. Once you have docs it'll be easier to reason about what this is and thus what we should call it.

[n0tlu5]

compiled 5f3a65f, i can provide the docker image if needed

[Habbie]

code looks decent. Still needs documentation and a test.

[n0tlu5]

should i resolve those failing checks?
i do not understand the "CodeQL and clang-tidy" check

[miodvallat]

should i resolve those failing checks? i do not understand the "CodeQL and clang-tidy" check

Yes, please. You need to add the new function name to the extra words list of the spell checker. The clang-tidy results are indeed not always easy to find. Here they are, for the lines changed by your PR:

Warning: pdns/lua-record.cc:90: parameter name 'cd' is too short, expected at least 3 characters (readability-identifier-length)
Warning: pdns/lua-record.cc:245: parameter name 'cd' is too short, expected at least 3 characters (readability-identifier-length)
Warning: pdns/lua-record.cc:275: parameter name 'cd' is too short, expected at least 3 characters (readability-identifier-length)
Warning: pdns/lua-record.cc:1196: statement should be inside braces (readability-braces-around-statements)
Warning: pdns/lua-record.cc:1200: converting integer literal to bool, use bool literal instead (modernize-use-bool-literals)
Warning: pdns/lua-record.cc:1200: implicit conversion 'int' -> bool (readability-implicit-bool-conversion)
Warning: pdns/lua-record.cc:1207: converting integer literal to bool, use bool literal instead (modernize-use-bool-literals)
Warning: pdns/lua-record.cc:1207: implicit conversion 'int' -> bool (readability-implicit-bool-conversion)

They should be easy to address, or you can add //NOLINT(readability-identifier-length) to the first three cases, to avoid having to touch too many lines of code. The other points (braces for single-statement if and explicit casts) need to be addressed, though.

[omoerbeek]

should i resolve those failing checks? i do not understand the "CodeQL and clang-tidy" check

You can see the reported issues in context i the "Files changed" tab.

[n0tlu5]

the statement inside braces check confuses me

[n0tlu5]

the check still fails

[miodvallat]

Please use NOLINTNEXTLINE instead of NOLINT when the comment concerns the following line. That ought to appease clang-tidy.