Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: Backport 15010 to rec 5.2.x: fix protobufServer(.. {taggedOnly=true}) logic for cache-returned responses #15015

Open
wants to merge 5 commits into
base: rel/rec-5.2.x
Choose a base branch
from
Open

rec: Backport 15010 to rec 5.2.x: fix protobufServer(.. {taggedOnly=true}) logic for cache-returned responses #15015

wants to merge 5 commits into from
+61 −49

Conversation

omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Jan 6, 2025 •
edited
Loading

Short description

Backport of #15010

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

g0tar and others added 5 commits January 6, 2025 13:34
@g0tar @omoerbeek
recursor: fix protobufServer(.. {taggedOnly=true}) logic for
2815457 
cache-returned responses (problem existing since initial ac10822)
fixes PowerDNS#15007

(cherry picked from commit 647162c)
@g0tar @omoerbeek
rec: TCP counterpart to protobufServer(.. {taggedOnly=true}) fix
dd61803 
(cherry picked from commit fc26c93)
@g0tar @omoerbeek
typo
eda261e 
(cherry picked from commit fb07dc1)
@g0tar @omoerbeek
recursor: outgoingProtobufServer() ignores taggedOnly protobuf option,
de33e10 
therefore do not annouce it; outgoing server is used as outgoingLoggers
in LWResult::Result asyncresolve(); after being introduced in
4898a34 filtering of outgoingP..S..() was not implemented since b790ef3

(cherry picked from commit d840333)
@omoerbeek
Test the non-tagged packet cache hit case and test both UDP and TCP c…
de1a487 
…lients while there

(cherry picked from commit 5600caf)
@omoerbeek omoerbeek added this to the rec-5.2.0 milestone Jan 6, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12632647872

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 24 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.003%) to 66.452%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/sortlist.cc 2 74.12%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/recursordist/syncres.cc 4 79.43%
pdns/recursordist/test-syncres_cc1.cc 5 89.7%
pdns/recursordist/rec-tcp.cc 10 65.55%
Totals Coverage Status
Change from base Build 12313058664: 0.003%
Covered Lines: 57886
Relevant Lines: 77110
💛 - Coveralls

@omoerbeek omoerbeek requested a review from rgacogne January 8, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne Awaiting requested review from rgacogne

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
defect rec
Projects
None yet
Milestone
rec-5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@omoerbeek @coveralls @g0tar