Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OneBranch pipeline and dependencies #253

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Update OneBranch pipeline and dependencies #253

merged 1 commit into from
Sep 5, 2024

Conversation

andyleejordan
Copy link
Member

See title.

@andyleejordan andyleejordan marked this pull request as ready for review September 4, 2024 18:35
@andyleejordan andyleejordan enabled auto-merge (squash) September 4, 2024 18:36
SeeminglyScience
SeeminglyScience approved these changes Sep 5, 2024
View reviewed changes
Copy link

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JamesWTruher
JamesWTruher approved these changes Sep 5, 2024
View reviewed changes
Copy link

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine

I wonder if installPSResources could be made more generalized and take a list of resources, that way you could combine the changes in the yml and have installPSResources bootstrap PSResourceGet too

@andyleejordan andyleejordan merged commit 2078bf3 into main Sep 5, 2024
6 checks passed
@andyleejordan andyleejordan deleted the test/onebranch branch September 5, 2024 16:29
@andyleejordan
Copy link
Member Author

@JamesWTruher I intend to be able to remove the PSResourceGet bootstrapping ASAP as we'll have PowerShell 7.4 in the OneBranch container where the YAML is executed, soon. ("YAML is executed" 😵)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyleejordan @JamesWTruher @SeeminglyScience