Add anvil saver example #1222
Merged
Add anvil saver example #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karang
reviewed
Aug 9, 2020
lib/plugins/blocks.js
Outdated
| const nbt = require('prismarine-nbt') | ||
| const Block = require('prismarine-block')(version) | ||
| const Chunk = require('prismarine-chunk')(version) | ||
| const ChatMessage = require('prismarine-chat')(version) | ||
| const World = require('prismarine-world')(version) | ||
| bot.world = new World().sync | ||
| bot.world = new World(null, storageBuilder ? storageBuilder({ version: bot.version, worldName: 'overworld' }) : null).sync |
There was a problem hiding this comment.
What happen if we move to nether or the end ? Should a single World instance deal with all dimensions ?
There was a problem hiding this comment.
That's in the respawn line in blocks.js, a new world instance is created. worldName will be nether in this case
That's why storageBuilder is a function, so you can call it several time.
One world should handle only one dimension imho
(but indeed I actually hardcoded overworld in blocks.js, will add at least nether)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#334