pc1.18+: Fix world height defaults and light masks #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The world height changed in 1.18+ to be between -64 and +320. The value set to the ChunkColumn have to be aligned with the dimension codec or the game will sometimes crash the game and otherwise cause chunks to be misplaced. Since we don't have a way to store this data inside prismarine-registry yet I just fix by changing the defaults to be correct. Also fix for light masks
|
would be nice to have a regression test for this kind of stuff |
|
/makerelease |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The world height changed in 1.18+ to be between -64 and +320. The value set to the ChunkColumn have to be aligned with the dimension codec or the game will sometimes crash the game and otherwise cause chunks to be misplaced, eg:
Since we don't have a way to store this data inside prismarine-registry yet I just fix by changing the defaults to be correct 1.18 defaults
Also fix for light masks