Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw with error messages or SERVER_ERROR if network response is not ok #1322

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Throw with error messages or SERVER_ERROR if network response is not ok #1322

merged 2 commits into from
Dec 15, 2023

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Dec 15, 2023

Fixes #1321

@ryanio ryanio requested a review from a team December 15, 2023 16:13
@ryanio ryanio merged commit 6e18171 into main Dec 15, 2023
8 checks passed
@ryanio ryanio deleted the ryan/throw-server-error-if-response-not-ok branch December 15, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cterech cterech cterech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenSeaAPI.postOrder doesn't properly handle response errors
2 participants
@ryanio @cterech