assign the order hash a bit later

ProjectOpenSea · Feb 10, 2024 · 33a9915 · 33a9915
1 parent 346094d
commit 33a9915
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/core/lib/OrderFulfiller.sol b/src/core/lib/OrderFulfiller.sol
@@ -121,7 +121,6 @@ contract OrderFulfiller is
 
         // Declare empty bytes32 array and populate with the order hash.
         bytes32[] memory orderHashes = new bytes32[](1);
-        orderHashes[0] = orderHash;
 
         if (advancedOrder.parameters.orderType != OrderType.CONTRACT) {
             _assertRestrictedAdvancedOrderAuthorization(
@@ -195,6 +194,8 @@ contract OrderFulfiller is
 
         _transferEach(orderParameters, fulfillerConduitKey);
 
+        orderHashes[0] = orderHash;
+
         // Ensure restricted orders have a valid submitter or pass a zone check.
         _assertRestrictedAdvancedOrderValidity(
             advancedOrders[0], orderHashes, orderHash