defer state write until after authorizeOrder call on basic

ProjectOpenSea · Feb 3, 2024 · 4335bd0 · 4335bd0
1 parent 8f3e1cd
commit 4335bd0
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/reference/lib/ReferenceBasicOrderFulfiller.sol b/reference/lib/ReferenceBasicOrderFulfiller.sol
@@ -345,15 +345,6 @@ contract ReferenceBasicOrderFulfiller is ReferenceOrderValidator {
             offeredItemType
         );
 
-        // Determine whether order is restricted and, if so, that it is valid.
-        _assertRestrictedBasicOrderAuthorization(
-            orderHash,
-            orderType,
-            parameters,
-            offeredItemType,
-            receivedItemType
-        );
-
         // Determine conduitKey argument used by transfer functions.
         bytes32 conduitKey;
         if (
@@ -824,6 +815,15 @@ contract ReferenceBasicOrderFulfiller is ReferenceOrderValidator {
             );
         }
 
+        // Determine whether order is restricted and, if so, that it is valid.
+        _assertRestrictedBasicOrderAuthorization(
+            hashes.orderHash,
+            orderType,
+            parameters,
+            offeredItemType,
+            receivedItemType
+        );
+
         // Verify and update the status of the derived order.
         _validateBasicOrderAndUpdateStatus(
             hashes.orderHash,