Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/226 #227

Merged
merged 2 commits into from
May 5, 2024
Merged

Issues/226 #227

merged 2 commits into from
May 5, 2024

Conversation

MichelleBlanchette
Copy link
Collaborator

No description provided.

…ad of throwing an exception when the Asana\Client can't be authorized
…WordPress user is currently logged in rather than make Asana API calls to test authentication; WordPress runs the permission callbacks of all routes upon registration, not just when the specific endpoint is called upon
Copy link
Collaborator Author

@MichelleBlanchette MichelleBlanchette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, much better. What an interesting discovery on how/when/why WordPress actually executes the endpoint permission callbacks...

@MichelleBlanchette MichelleBlanchette marked this pull request as ready for review May 5, 2024 16:40
@MichelleBlanchette MichelleBlanchette merged commit 5d3d209 into develop May 5, 2024
1 check passed
@MichelleBlanchette MichelleBlanchette deleted the issues/226 branch May 5, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error logging can break JSON responses from the REST API if display_errors is enabled
1 participant