Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload end point #1555

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Upload end point #1555

merged 4 commits into from
Dec 17, 2024

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Dec 16, 2024

Summary

Following the work done in #1529 this PR refactors the upload end-point. The process followed was very similar:

This PR enables files/upload and files/provider/upload end-points to be able to upload the files to the user and provider directory.

Details and comments

  • files/upload end-point was separated in two:
    • files/upload now contains the paths: username/ and username/provider/function. Following the previous development, with the purpose to separate paths where to upload the files from functions from the user's root folder.
    • files/provider/upload to manage the path provider/function so now each function will have its own folder in the provider directory to upload the files.

@Tansito Tansito requested a review from a team December 16, 2024 21:50
@Tansito Tansito changed the base branch from main to data-folder December 16, 2024 21:50
@Tansito Tansito changed the title Update end point Upload end point Dec 17, 2024
Copy link
Collaborator

@korgan00 korgan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tansito
Copy link
Member Author

Tansito commented Dec 17, 2024

I'm going to review first #1554 so if I can merge it I can fix the conflicts at my evening

# Conflicts:
#	gateway/api/services/file_storage.py
#	gateway/api/v1/views/files.py
#	gateway/tests/api/test_v1_files.py
@Tansito Tansito merged commit 5bdb776 into data-folder Dec 17, 2024
7 of 8 checks passed
@Tansito Tansito deleted the update-end-point branch December 17, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants