Refactor summary row #254

jwildfire · 2018-04-11T18:19:21Z

This PR covers most of the new user-facing functionality in v1.4.0. Test notes are in the issues listed below.

closes #187 #251 #252 #256 #258 #259 #260

…ad two files with the same label

samussiah · 2018-05-02T15:25:24Z

src/charts/spark/makeHist.js

@@ -0,0 +1,82 @@
+export default function makeHist(this_, d) {


Super slick.

samussiah · 2018-05-02T15:39:55Z

src/codebook/summaryTable/renderRow/makeTitle.js

+    .attr('class', 'percent-missing')
+    .text(d => d3format('0.1%')(d.statistics.percentMissing) + ' missing')
+    .style('display', d => (d.statistics.percentMissing == 0 ? 'none' : null))
+    .style('cursor', 'pointer')


To filter out missing records on a click event?

samussiah · 2018-05-02T15:43:20Z

src/codebook/title/updateCountSummary.js

@@ -0,0 +1,40 @@
+import { format as d3format } from 'd3';


Makes a lot more sense up here.

samussiah

The mini-plots kick butt and moving the variable details between the variable header and the chart improves the feng shui, as does moving the dataset summary to above the nav tabs. Nice work!

…te to source local files

add code that waits until the loading state of the document is comple…

danedexF5 · 2018-05-23T20:15:43Z

@jwildfire I wrote notes on each issue here. Some of them seem to be fine outside of a small thing or 2 (for example, the functionality is fine in FF and Chrome but the Test page won't work in IE)
#187:
-"Confirm that a text-based summary of the variable appears above the chart when a row is expanded" Not seeing this when a variable is expanded.
-Test page isn't rendering in IE
#251:
-" Confirm that column count is hidden by default (when 100% of the columns are selected)" Not sure how to test this as it seems we're confirming a negative. Column Count is hidden, when I hide a column in settings, it does give me the number of hidden columns next to row count. Is this the confirmation we're looking for?
#252:
-If the threshold is hard coded to anything missing above .1 will highlight red then right now it doesn't appear to be right. I am seeing values above .1 that don't highlight red.
#256:
-"Confirm that the shape of the distribution mimics the larger chart (click "show all charts" to see the large charts)" Not sure what this means but the numbers of the chart to the right of the variable headers appears to match the larger charts within the variables.
-"Confirm that continuous variables have black bars while categorical variables have gray bars" I'm not seeing any black bars, how can I filter for a continuous variable? I do see some gray bars with blacks caps on the end of them.
#258: Only issue appears to be the same problem of the test page not loading in IE.
#259: Only issue appears to be the same problem of the test page not loading in IE.
#260: No Issues.

jwildfire · 2018-05-24T15:27:42Z

@danedexF5 Can you please make a new issue to cover the IE bug? I'll take a look ASAP and decide if we need to deal with it in v1.4 or if it can wait.

danedexF5 · 2018-05-25T19:15:34Z

@jwildfire Sure, I'll create an issue now. To clarify a little, I restarted and I can get one test page to come up in IE (https://rawgit.com/RhoInc/web-codebook/refactor-summary-row/build/test-page/) and one still will not (https://rawgit.com/RhoInc/web-codebook/refactor-summary-row/build/test-page/explorer.html). So it appears the issue is with the explorer part of it.

Fix multiple file labels in explorer

jwildfire · 2018-05-31T18:56:44Z

#187 @danedexF5 just refers to this section of the variable summary (text-based might not be the best identifier.

jwildfire · 2018-05-31T18:57:50Z

#251 @danedexF5 yep, I think the test you describe above confirms functionality for the column counts.

jwildfire · 2018-05-31T19:04:52Z

#252 @danedexF5 Can you please create a bug and document the steps to reproduce the situation when a missing value >10% isn't red.

jwildfire · 2018-05-31T19:07:26Z

#256 I think the color difference in the header charts is probably too subtle to notice ('cyl' is gray and 'mpg' is black in the screenshot below). Going to make an issue for a future release to change the categorical bars to a dark blue and see if that makes them easier to distinguish.

danedexF5 · 2018-05-31T19:11:18Z

#252 @jwildfire disregard my note on this one. I was mistaken and not converting to %'s, so it appears to be working as expected. 10% and above is red, below 10% is grey.

jwildfire added 14 commits April 11, 2018 06:27

Merge branch 'unique-selectors' into v1.4.0-dev

bfd198d

merge test page branch

2167ec9

don't automatically open test pages on build

b6bb537

local testing

79801bf

import clone

b680399

start layout refactor #187

407c72a

summary table refactor underway. #187

b267188

updated controls/toggle for new layout. #187

4215b6f

pull type tag left. #187

7dd9179

add metadata as tags

646ad75

add metadata as tags

92b0d8f

add basic explorer page

5b45b09

add SDTM metadata to explorer

810da15

hide metadata when details are collapsed

9bdd804

jwildfire added 6 commits April 14, 2018 10:43

framework for sparklines #256

daa356e

sparklines #256

8a943f0

update explorer example

f9d178a

minor sparkline improvements

114bd9f

change lines to 50-bin histograms for continuous

9ba20b5

refactor row/col counts. fix #251

8f7af87

jwildfire added 2 commits April 18, 2018 09:41

clean up console logs and explorer example

3128920

fix callbacks on cloned codebook. fixed #259

c2260b3

jwildfire requested a review from samussiah April 18, 2018 17:55

jwildfire and others added 3 commits April 19, 2018 09:50

fix hover css. fix #260

d8b943a

fix the explorer so that it indicates which file is loaded and can lo…

0e44aed

…ad two files with the same label

remove stray console.logs()s

50cf647

samussiah reviewed May 2, 2018

View reviewed changes

src/charts/spark/makeHist.js

@@ -0,0 +1,82 @@

export default function makeHist(this_, d) {

Copy link

Contributor

samussiah May 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super slick.

samussiah reviewed May 2, 2018

View reviewed changes

samussiah approved these changes May 2, 2018

View reviewed changes

jwildfire and others added 4 commits May 11, 2018 10:33

Fix typo

6b349b8

add code that waits until the loading state of the document is comple…

e101fd3

…te to source local files

Merge branch 'v1.4.0-dev' into explorer-fix

533d56b

Merge pull request #265 from RhoInc/test-page-fix

6500f18

add code that waits until the loading state of the document is comple…

jwildfire and others added 4 commits May 30, 2018 20:32

build type fix

f05faab

merge v1.4.0-dev updates

ae1b3dd

merge refactor-summary-row brach

6bdd270

Merge pull request #263 from RhoInc/explorer-fix

c2d7528

Fix multiple file labels in explorer

jwildfire merged commit fe8376d into v1.4.0-dev May 31, 2018

samussiah deleted the refactor-summary-row branch June 11, 2018 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor summary row #254

Refactor summary row #254

jwildfire commented Apr 11, 2018 •

edited

Loading

samussiah May 2, 2018

samussiah May 2, 2018 •

edited

Loading

samussiah May 2, 2018

samussiah left a comment

danedexF5 commented May 23, 2018 •

edited

Loading

jwildfire commented May 24, 2018 •

edited

Loading

danedexF5 commented May 25, 2018

jwildfire commented May 31, 2018 •

edited

Loading

jwildfire commented May 31, 2018 •

edited

Loading

jwildfire commented May 31, 2018

jwildfire commented May 31, 2018 •

edited

Loading

danedexF5 commented May 31, 2018

		@@ -0,0 +1,82 @@
		export default function makeHist(this_, d) {

Refactor summary row #254

Refactor summary row #254

Conversation

jwildfire commented Apr 11, 2018 • edited Loading

samussiah May 2, 2018

Choose a reason for hiding this comment

samussiah May 2, 2018 • edited Loading

Choose a reason for hiding this comment

samussiah May 2, 2018

Choose a reason for hiding this comment

samussiah left a comment

Choose a reason for hiding this comment

danedexF5 commented May 23, 2018 • edited Loading

jwildfire commented May 24, 2018 • edited Loading

danedexF5 commented May 25, 2018

jwildfire commented May 31, 2018 • edited Loading

jwildfire commented May 31, 2018 • edited Loading

jwildfire commented May 31, 2018

jwildfire commented May 31, 2018 • edited Loading

danedexF5 commented May 31, 2018

jwildfire commented Apr 11, 2018 •

edited

Loading

samussiah May 2, 2018 •

edited

Loading

danedexF5 commented May 23, 2018 •

edited

Loading

jwildfire commented May 24, 2018 •

edited

Loading

jwildfire commented May 31, 2018 •

edited

Loading

jwildfire commented May 31, 2018 •

edited

Loading

jwildfire commented May 31, 2018 •

edited

Loading