Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.5.0 release #114

Merged
merged 16 commits into from
Oct 25, 2024
Merged

Prepare 0.5.0 release #114

merged 16 commits into from
Oct 25, 2024

Conversation

Aeilert
Copy link
Collaborator

@Aeilert Aeilert commented Oct 3, 2024

  • Bump version
  • Fix URL bug
  • Bump roxygen2 version

* Bump version
* Fix URL bug
* Bump roxygen2 version
@Aeilert Aeilert added the Release label Oct 3, 2024
@Aeilert Aeilert requested a review from ohjakobsen October 3, 2024 11:31
@Aeilert Aeilert self-assigned this Oct 3, 2024
@ohjakobsen
Copy link
Contributor

@Aeilert: We need to add @return/@returns and @examples to all exported functions before submitting. Most other checks seem to be OK for the moment. See this page for details.

@ohjakobsen
Copy link
Contributor

I've added examples and return values to exported functions and have fixed a couple of bugs. @Aeilert: can you go through a last time to check if we have missed anything?

* Standardise examples across functions
* Fix a few typos
* Use dontrun for run_pioneer example
@Aeilert
Copy link
Collaborator Author

Aeilert commented Oct 16, 2024

I've added examples and return values to exported functions and have fixed a couple of bugs. @Aeilert: can you go through a last time to check if we have missed anything?

Hi @ohjakobsen. I made a few minor changes in the documentation, particularly to standardise how examples are written across different functions. I also converted the run_pioneer() example to a dontrun{} variant. The main reason for this is that the app would spin up when running devtools::run_examples() making a bit tricky to check all the examples in a simple manner.

Otherwise I think everything looks good. :)

@ohjakobsen
Copy link
Contributor

CRAN might balk at \dontrun, but I agree in principle. Let's go for submitting the package!

Copy link
Contributor

@ohjakobsen ohjakobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pioneeR has been accepted and published on CRAN!

@ohjakobsen ohjakobsen merged commit 6e66148 into master Oct 25, 2024
7 checks passed
@ohjakobsen ohjakobsen deleted the release-0.5.0 branch October 25, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants