Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working bubble columns #570

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Caedis
Copy link

@Caedis Caedis commented Jan 5, 2025

todo:

  • Particles when something is bobbing
  • Bobbing on the top of an upward bubble column
  • Swap animations. Soul sand animation is currently going down and the magma block one is going up. Reference

@Roadhog360
Copy link
Owner

Oops

There is a very dirty registry I made somewhere to determine which blocks makw up/down columns, you can flip them there.

Even if it's not 100% done I'll pull the PR if you don't plan on scratching off the rest of the todo any time soon.

I'm currently in the middle of a pretty lengthy rewrite. That's gonna take a long time. So, I don't mind putting in PRs in parts.

@Caedis
Copy link
Author

Caedis commented Jan 5, 2025

The bobbing should do doable

@Caedis Caedis marked this pull request as ready for review January 5, 2025 07:39
@Caedis
Copy link
Author

Caedis commented Jan 5, 2025

client bubbling particles i mean*

@Caedis
Copy link
Author

Caedis commented Jan 5, 2025

and that is why formatting should always be in its own commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants