version 1.20.1

SAP · Nov 11, 2024 · cec4cb5 · cec4cb5
1 parent ebb9be1
commit cec4cb5
Show file tree

Hide file tree

Showing 16 changed files with 70 additions and 32 deletions.
diff --git a/com.sap.adt.abapcleaner.app/abapcleaner.product b/com.sap.adt.abapcleaner.app/abapcleaner.product
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <?pde version="3.5"?>
 
-<product name="ABAP cleaner" uid="com.sap.adt.abapcleaner.app" application="com.sap.adt.abapcleaner.standalone.app" version="1.20.1.qualifier" type="features" includeLaunchers="true" autoIncludeRequirements="true">
+<product name="ABAP cleaner" uid="com.sap.adt.abapcleaner.app" application="com.sap.adt.abapcleaner.standalone.app" version="1.20.1" type="features" includeLaunchers="true" autoIncludeRequirements="true">
 
    <configIni use="default">
    </configIni>

diff --git a/com.sap.adt.abapcleaner.app/pom.xml b/com.sap.adt.abapcleaner.app/pom.xml
@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>com.sap.adt.abapcleaner.app</artifactId>
-  <version>1.20.1-SNAPSHOT</version>
+  <version>1.20.1</version>
   <name>com.sap.adt.abapcleaner.app</name>
   <packaging>eclipse-repository</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.20.1-SNAPSHOT</version>
+    <version>1.20.1</version>
     <relativePath>../</relativePath>
   </parent>
 

diff --git a/com.sap.adt.abapcleaner.feature/feature.xml b/com.sap.adt.abapcleaner.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="com.sap.adt.abapcleaner.feature"
       label="ABAP cleaner"
-      version="1.20.1.qualifier">
+      version="1.20.1">
 
    <description>
       ABAP cleaner plug-in for ABAP Development Tools

diff --git a/com.sap.adt.abapcleaner.feature/pom.xml b/com.sap.adt.abapcleaner.feature/pom.xml
@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <artifactId>com.sap.adt.abapcleaner.feature</artifactId>
   <groupId>com.sap.adt.abapcleaner</groupId>
-  <version>1.20.1-SNAPSHOT</version>
+  <version>1.20.1</version>
   <name>com.sap.adt.abapcleaner.feature</name>
   <packaging>eclipse-feature</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.20.1-SNAPSHOT</version>
+    <version>1.20.1</version>
     <relativePath>../</relativePath>
   </parent>
 

diff --git a/com.sap.adt.abapcleaner.gui/META-INF/MANIFEST.MF b/com.sap.adt.abapcleaner.gui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: com.sap.adt.abapcleaner.gui;singleton:=true
-Bundle-Version: 1.20.1.qualifier
+Bundle-Version: 1.20.1
 Bundle-Vendor: %Provider-Name
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-17

diff --git a/com.sap.adt.abapcleaner.gui/pom.xml b/com.sap.adt.abapcleaner.gui/pom.xml
@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>com.sap.adt.abapcleaner.gui</artifactId>
-  <version>1.20.1-SNAPSHOT</version>
+  <version>1.20.1</version>
   <name>com.sap.adt.abapcleaner.gui</name>
   <packaging>eclipse-plugin</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.20.1-SNAPSHOT</version>
+    <version>1.20.1</version>
     <relativePath>../</relativePath>
   </parent>
 

diff --git a/com.sap.adt.abapcleaner.updatesite/pom.xml b/com.sap.adt.abapcleaner.updatesite/pom.xml
@@ -2,14 +2,14 @@
 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0">
   <modelVersion>4.0.0</modelVersion>
   <artifactId>com.sap.adt.abapcleaner.updatesite</artifactId>
-  <version>1.20.1-SNAPSHOT</version>
+  <version>1.20.1</version>
   <name>ABAP Cleaner for ABAP Development Tools (ADT)</name>
   <packaging>eclipse-repository</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.20.1-SNAPSHOT</version>
+    <version>1.20.1</version>
     <relativePath>../</relativePath>
   </parent>
 

diff --git a/com.sap.adt.abapcleaner/META-INF/MANIFEST.MF b/com.sap.adt.abapcleaner/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: com.sap.adt.abapcleaner;singleton:=true
-Bundle-Version: 1.20.1.qualifier
+Bundle-Version: 1.20.1
 Bundle-Vendor: %Provider-Name
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-17

diff --git a/com.sap.adt.abapcleaner/pom.xml b/com.sap.adt.abapcleaner/pom.xml
@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>com.sap.adt.abapcleaner</artifactId>
-  <version>1.20.1-SNAPSHOT</version>
+  <version>1.20.1</version>
   <name>com.sap.adt.abapcleaner</name>
   <packaging>eclipse-plugin</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.20.1-SNAPSHOT</version>
+    <version>1.20.1</version>
     <relativePath>../</relativePath>
   </parent>
 

diff --git a/docs/release-notes.md b/docs/release-notes.md
@@ -6,6 +6,16 @@ as well as bugfixes of reported issues, i.e. anything that enhances or changes t
 For a complete list of changes (including documentation, tests, refactoring etc.), please refer to 
 the list of [commits](../../../commits/main).
 
+## 2024-11-11 (version 1.21.1)
+
+**Thank you** very much, [**openPhiL**](https://github.com/openPhiL) and
+ [**ConjuringCoffee**](https://github.com/ConjuringCoffee), for your bug reports!
+
+* Fixed rule '**Replace CONDENSE with string function**' for **structured types** ([#371](../../../issues/371))
+* Fixed rule '**Simplify a chain with one element**' for **first command in code** document ([#372](../../../issues/372))
+* Fixed rule '**Align METHODS declarations**' for FINAL with **FOR EVENT** ([#373](../../../issues/373))
+* Updated known CamelCase names
+
 ## 2024-10-19 (version 1.20.0)
 
 **Great thanks** to [**ConjuringCoffee**](https://github.com/ConjuringCoffee) for the issue behind the custom view and field names!

diff --git a/docs/rules.md b/docs/rules.md
@@ -1,6 +1,6 @@
 # Available Cleanup Rules
 
-ABAP cleaner offers 98 cleanup rules with a total of 461 configuration options:
+ABAP cleaner offers 98 cleanup rules with a total of 462 configuration options:
 
 ## Empty Lines
 

diff --git a/docs/rules/CondenseRule.md b/docs/rules/CondenseRule.md
@@ -18,20 +18,28 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 * \[ \] Explicitly specify parameter del = \` \`, except for NO-GAPS
 * \[X\] Explicitly specify parameter from = \` \` for NO-GAPS
 * \[ \] Keep parameters on one line \(see rule 'Align parameters and components', option 'Keep other one-liners'\)
+* \[X\] Only replace CONDENSE for known unstructured types \(STRING, C, N, CHAR10 etc.\)
+* Warning: deactivating this option might lead to syntax errors if your code contains CONDENSE with structured types \(but at least the syntax check will immediately show this\)
 
 ## Examples
 
 
 ```ABAP
 
   METHOD replace_condense.
+    TYPES: BEGIN OF ty_s_any_struc,
+             field TYPE c LENGTH 10,
+           END OF ty_s_any_struc.
+
     CONSTANTS lc_abc_with_gaps TYPE string VALUE `  a   b   c  `.
 
-    DATA lv_text_a   TYPE char30 VALUE lc_abc_with_gaps.
-    DATA lv_text_b   TYPE char30 VALUE lc_abc_with_gaps.
-    DATA lv_text_c   TYPE char30 VALUE lc_abc_with_gaps.
-    DATA lv_string_a TYPE string VALUE lc_abc_with_gaps.
-    DATA lv_string_b TYPE string VALUE lc_abc_with_gaps.
+    DATA lv_text_a      TYPE char30 VALUE lc_abc_with_gaps.
+    DATA lv_text_b      TYPE char30 VALUE lc_abc_with_gaps.
+    DATA lv_text_c      TYPE char30 VALUE lc_abc_with_gaps.
+    DATA lv_string_a    TYPE string VALUE lc_abc_with_gaps.
+    DATA lv_string_b    TYPE string VALUE lc_abc_with_gaps.
+    DATA ls_structure   TYPE ty_s_any_struc.
+    DATA l_unknown_type TYPE if_any_interface=>ty_unknown_type.
 
     " condense first text field to 'a b c', second one to 'abc'
     CONDENSE lv_text_a.
@@ -44,6 +52,13 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
     " condense text field with offset 5 and length 7 to `  a  b c`
     " (specifying offset and length in write positions is possible for text fields, but not for strings)
     CONDENSE lv_text_c+5(7).
+
+    " unlike CONDENSE, the string function condense( ) does not work on structured data; therefore,
+    " changing the next statements might cause syntax errors. You can activate the option
+    " 'Only replace CONDENSE for known unstructured types' to restrict this cleanup rule
+    " to cases in which ABAP cleaner can clearly determine the type (as above)
+    CONDENSE ls_structure.
+    CONDENSE l_unknown_type.
   ENDMETHOD.
 ```
 
@@ -52,13 +67,19 @@ Resulting code:
 ```ABAP
 
   METHOD replace_condense.
+    TYPES: BEGIN OF ty_s_any_struc,
+             field TYPE c LENGTH 10,
+           END OF ty_s_any_struc.
+
     CONSTANTS lc_abc_with_gaps TYPE string VALUE `  a   b   c  `.
 
-    DATA lv_text_a   TYPE char30 VALUE lc_abc_with_gaps.
-    DATA lv_text_b   TYPE char30 VALUE lc_abc_with_gaps.
-    DATA lv_text_c   TYPE char30 VALUE lc_abc_with_gaps.
-    DATA lv_string_a TYPE string VALUE lc_abc_with_gaps.
-    DATA lv_string_b TYPE string VALUE lc_abc_with_gaps.
+    DATA lv_text_a      TYPE char30 VALUE lc_abc_with_gaps.
+    DATA lv_text_b      TYPE char30 VALUE lc_abc_with_gaps.
+    DATA lv_text_c      TYPE char30 VALUE lc_abc_with_gaps.
+    DATA lv_string_a    TYPE string VALUE lc_abc_with_gaps.
+    DATA lv_string_b    TYPE string VALUE lc_abc_with_gaps.
+    DATA ls_structure   TYPE ty_s_any_struc.
+    DATA l_unknown_type TYPE if_any_interface=>ty_unknown_type.
 
     " condense first text field to 'a b c', second one to 'abc'
     lv_text_a = condense( lv_text_a ).
@@ -74,7 +95,14 @@ Resulting code:
 
     " condense text field with offset 5 and length 7 to `  a  b c`
     " (specifying offset and length in write positions is possible for text fields, but not for strings)
-    lv_text_c+5(7) = condense( lv_text_c+5(7) ).
+    CONDENSE lv_text_c+5(7).
+
+    " unlike CONDENSE, the string function condense( ) does not work on structured data; therefore,
+    " changing the next statements might cause syntax errors. You can activate the option
+    " 'Only replace CONDENSE for known unstructured types' to restrict this cleanup rule
+    " to cases in which ABAP cleaner can clearly determine the type (as above)
+    CONDENSE ls_structure.
+    CONDENSE l_unknown_type.
   ENDMETHOD.
 ```
 

diff --git a/pom.xml b/pom.xml
@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>parent</artifactId>
-  <version>1.20.1-SNAPSHOT</version>
+  <version>1.20.1</version>
   <name>ABAP cleaner</name>
   <packaging>pom</packaging>
   <modules>

diff --git a/test/com.sap.adt.abapcleaner.test/META-INF/MANIFEST.MF b/test/com.sap.adt.abapcleaner.test/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Unit Tests for com.sap.adt.abapcleaner
 Bundle-SymbolicName: com.sap.adt.abapcleaner.test;singleton:=true
-Bundle-Version: 1.20.1.qualifier
+Bundle-Version: 1.20.1
 Bundle-Vendor: abap-dev
 Fragment-Host: com.sap.adt.abapcleaner
 Bundle-RequiredExecutionEnvironment: JavaSE-17

diff --git a/test/com.sap.adt.abapcleaner.test/pom.xml b/test/com.sap.adt.abapcleaner.test/pom.xml
@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>com.sap.adt.abapcleaner.test</artifactId>
-  <version>1.20.1-SNAPSHOT</version>
+  <version>1.20.1</version>
   <name>com.sap.adt.abapcleaner.test</name>
   <packaging>eclipse-test-plugin</packaging>
 
   <parent>
     <artifactId>tests</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.20.1-SNAPSHOT</version>
+    <version>1.20.1</version>
     <relativePath>../</relativePath>
   </parent>
 

diff --git a/test/pom.xml b/test/pom.xml
@@ -4,14 +4,14 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>tests</artifactId>
-  <version>1.20.1-SNAPSHOT</version>
+  <version>1.20.1</version>
   <name>Test Fragments</name>
   <packaging>pom</packaging>
 
   <parent>
     <groupId>com.sap.adt.abapcleaner</groupId>
     <artifactId>parent</artifactId>
-    <version>1.20.1-SNAPSHOT</version>
+    <version>1.20.1</version>
     <relativePath>../</relativePath>
   </parent>