Added option single
to Instance.asdict() allowing to saving in multi-entity format
#653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #651
This PR adds the option
single
to Instance.asdict(). If you setsingle=False
the dict-representation will be in multi-entity format, which is the expected format for data instances.The default is currently set to
True
to retain the old behaviour. Ideally the default should beNone
, which would (like the json plugin) save metadata in single-entity format and data instances in multi-entity format.If we change the default to
None
, a set of tests will currently fail. Question: should we keep the old behaviour, or spend the time to update all failing tests?Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.